Skip to content

[otel_collector_internal_telemetry] Document data_stream.dataset and fix queries for TBS dashboards#19049

Merged
gregkalapos merged 4 commits into
elastic:mainfrom
gregkalapos:fix_dataset
May 26, 2026
Merged

[otel_collector_internal_telemetry] Document data_stream.dataset and fix queries for TBS dashboards#19049
gregkalapos merged 4 commits into
elastic:mainfrom
gregkalapos:fix_dataset

Conversation

@gregkalapos
Copy link
Copy Markdown
Contributor

@gregkalapos gregkalapos commented May 18, 2026

Queries in the Dashboards for tailsampling processor (TBS) used double otel which resulted in not fetching data for the dashboards.

The PR fixes the queries and also document that users must set data_stream.dataset to collectortelemetry.

This was reported by @ty-elastic.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@gregkalapos gregkalapos self-assigned this May 18, 2026
@gregkalapos gregkalapos added the bug Something isn't working, use only for issues label May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

✅ Vale Linting Results

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 18, 2026

💔 Build Failed

Failed CI Steps

History

cc @gregkalapos

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

TL;DR

Buildkite failed in package lint because packages/otel_collector_internal_telemetry/changelog.yml has invalid YAML at the new 1.2.1 changelog entry. Quote the description value on line 4 (it currently contains an unquoted :), then rerun the package check.

Remediation

  • In packages/otel_collector_internal_telemetry/changelog.yml:4, wrap the full description string in quotes, e.g.:
    - description: "Document `data_stream.dataset`: `collectortelemetry` and fix queries for TBS dashboards."
  • Re-run:
    .buildkite/scripts/test_one_package.sh packages/otel_collector_internal_telemetry origin/main ddef1c97a3eb67a1c990ec39522408865be0bb36
Investigation details

Root Cause

elastic-package fails to parse changelog.yml due to YAML syntax error (mapping values are not allowed in this context).

The offending line is in the PR commit (ddef1c97a3eb67a1c990ec39522408865be0bb36):

  • packages/otel_collector_internal_telemetry/changelog.yml:4
  • - description: Document data_stream.dataset: collectortelemetry and fix queries for TBS dashboards.

Because the scalar is unquoted and contains :, YAML treats it as a mapping delimiter and parsing fails.

Evidence

  • Build: https://buildkite.com/elastic/integrations/builds/43005
  • Job/step: Check integrations otel_collector_internal_telemetry
  • Key log excerpt:
    Error: checking package failed: linting package failed: found 3 validation errors:
    file ".../packages/otel_collector_internal_telemetry/changelog.yml" is invalid:
    unmarshalling YAML file failed: yaml: line 4: mapping values are not allowed in this context
    

Verification

  • Not run locally for this PR head because the failing commit is not present in the local checkout; diagnosis is based on Buildkite logs plus the file content at commit ddef1c97a3eb67a1c990ec39522408865be0bb36.

Follow-up

  • If the same lint error persists after quoting line 4, check other newly added changelog lines for unquoted : in plain scalars.

Note

🔒 Integrity filter blocked 8 items

The following items were blocked because they don't meet the GitHub integrity level.

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @gregkalapos

@gregkalapos gregkalapos marked this pull request as ready for review May 18, 2026 15:53
@gregkalapos gregkalapos requested a review from a team as a code owner May 18, 2026 15:53
@andrewkroh andrewkroh added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:otel_collector_internal_telemetry OpenTelemetry Collector Internal Telemetry dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels May 18, 2026
@gregkalapos gregkalapos merged commit 3dff9e6 into elastic:main May 26, 2026
11 checks passed
@gregkalapos gregkalapos deleted the fix_dataset branch May 26, 2026 12:15
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package otel_collector_internal_telemetry - 1.2.1 containing this change is available at https://epr.elastic.co/package/otel_collector_internal_telemetry/1.2.1/

herrBez pushed a commit to herrBez/integrations that referenced this pull request Jun 1, 2026
…fix queries for TBS dashboards (elastic#19049)

* Document data_stream.dataset and fix tbs queries

* Add changelog

* Update changelog.yml

* Update changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues dashboard Relates to a Kibana dashboard bug, enhancement, or modification. documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:otel_collector_internal_telemetry OpenTelemetry Collector Internal Telemetry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants