Skip to content

[Cisco ASA] Fix timezone handling#19184

Closed
bhapas wants to merge 3 commits into
elastic:mainfrom
bhapas:cisco_asa_timezone
Closed

[Cisco ASA] Fix timezone handling#19184
bhapas wants to merge 3 commits into
elastic:mainfrom
bhapas:cisco_asa_timezone

Conversation

@bhapas
Copy link
Copy Markdown
Contributor

@bhapas bhapas commented May 25, 2026

Summary

Fix timezone parsing in Cisco ASA and FTD ingest pipelines to support timezone abbreviations beyond US-centric 3-letter codes (e.g. WEST, CEST, BST, GMT, IST).

The TZ grok pattern was previously defined as (?:[APMCE][SD]T|UTC), which only matched EST, EDT, PST, PDT, MST, MDT, CST, CDT, AST, ADT, and UTC. Timezone abbreviations like WEST (Western European Summer Time) were silently dropped, causing timestamps to fall back to UTC and resulting in a 1-hour offset.

Changes:

  • Widened the TZ grok pattern to [a-zA-Z]{1,7}([+-]\d{1,2}(:\d{2})?)? — matches 1–7 letter abbreviations with an optional numeric offset suffix (e.g. UTC+1, CET+02:00)

Test plan

  • Verify existing test-asa-tz-mapping.log pipeline test still passes (EDT → America/New_York, PST → -08:00)
  • Test with a log containing WEST timezone — confirm @timestamp reflects +01:00 offset instead of UTC

@bhapas bhapas self-assigned this May 25, 2026
@bhapas bhapas added the Integration:cisco_asa Cisco ASA label May 25, 2026
@bhapas bhapas requested a review from a team as a code owner May 25, 2026 09:15
@bhapas bhapas added the bugfix Pull request that fixes a bug issue label May 25, 2026
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 25, 2026

💔 Build Failed

Failed CI Steps

History

cc @bhapas

@andrewkroh andrewkroh added the Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] label May 25, 2026
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

@bhapas bhapas closed this May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_asa Cisco ASA Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants