Skip to content

[Cisoc_asa] Allow underscores in hostnames and pool names#19192

Merged
robester0403 merged 4 commits into
elastic:mainfrom
robester0403:cisco-asa-parsing-issue-with-hyphens
May 25, 2026
Merged

[Cisoc_asa] Allow underscores in hostnames and pool names#19192
robester0403 merged 4 commits into
elastic:mainfrom
robester0403:cisco-asa-parsing-issue-with-hyphens

Conversation

@robester0403
Copy link
Copy Markdown
Contributor

Note: There are changes to the generated tests as an update to the current year.

Proposed commit message

Allow underscores in hostnames and pool names for ASA 305011 and 305012 messages.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
    - [ ] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

Screenshots

image

@robester0403 robester0403 requested a review from a team as a code owner May 25, 2026 21:14
@robester0403 robester0403 self-assigned this May 25, 2026
@robester0403 robester0403 added the Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] label May 25, 2026
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

@robester0403 robester0403 added bugfix Pull request that fixes a bug issue Integration:cisco_asa Cisco ASA labels May 25, 2026
Comment thread packages/cisco_asa/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@vinit-chauhan
Copy link
Copy Markdown
Contributor

Changes look good. Waiting for CI.

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @robester0403

@robester0403 robester0403 merged commit b21aded into elastic:main May 25, 2026
8 checks passed
@robester0403 robester0403 deleted the cisco-asa-parsing-issue-with-hyphens branch May 25, 2026 23:43
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package cisco_asa - 2.45.3 containing this change is available at https://epr.elastic.co/package/cisco_asa/2.45.3/

herrBez pushed a commit to herrBez/integrations that referenced this pull request Jun 1, 2026
)

Allow underscores in hostnames and pool names for ASA 305011 and 305012 messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_asa Cisco ASA Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants