[wiz] Various minor improvements#19203
Merged
Merged
Conversation
The logo was not showing in Firefox because it had embedded base64 encoded PNG data that was formatted with whitespace that isn't strictly allowed. Replaced with an actual vector version of the logo.
This is a workaround for elastic/beats#50867.
…able as an advanced options. May be helpful for debugging or workarounds.
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
…on finding data. The `analyzedAt` field remains and is mapped in the same way, but the `updatedAt` field is added and that's what's used for query filtering, as recommended by Wiz.
90427a2 to
d36b682
Compare
🚀 Benchmarks reportTo see the full report comment with |
kcreddy
reviewed
May 26, 2026
mohitjha-elastic
requested changes
May 27, 2026
56395f4 to
7dd4727
Compare
We expect just the base: `https://api.somedc.app.wiz.io`. Wiz provides an "API Endpoint" with the path: `https://api.somedc.app.wiz.io/graphql`, so that should work too. Better URL cleaning.
Testing shows that 5 rps should be okay (4 rps is fine for 10s, 8 rps occasionally returns 429). We have 5 data streams using the GraphQL API. Four run frequently (by default every 5 mins), one is a daily sync. Setting a request rate limit of 0.5 rps for each data stream means we should never exceed 2.5 rps in total, and never reach the rate limit. The only feedback from the server about the rate limit is that it responds with 429, with retry-after / reset information, once the limit has been exceeded. If a 429 response is received, the input will retry the request, respecting the retry-after period. We set a conservative static rate because the different data streams are unable to coordinate on the client side, and they receive no request budget feedback from the server side until its too late. We don't expect retries, but since they are possible due to rate limiting rather than just request or server errors, the maximum number of retry attempts is raised from 5 to 10.
Since apparently it can vary, and will be provided by Wiz along with the API Endpoint and credentials.
This was specifically requested by Wiz.
… data that has a transform.
…tion for data that has a transform." This reverts commit 166ea075774515ed3bade16d678318cedf9529b9.
7dd4727 to
13fa74f
Compare
💚 Build Succeeded
History
|
|
Package wiz - 4.3.0 containing this change is available at https://epr.elastic.co/package/wiz/4.3.0/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Note to reviewers
This is best read commit-by-commit.
It's batch of updates based on discussion with Wiz and a general review of the current state.
I'm open to breaking it into multiple PRs, if you think that's worthwhile.
Checklist
changelog.ymlfile.