Skip to content

[cisco_asa] Fix source and destination address parsing#19218

Merged
bhapas merged 1 commit into
elastic:mainfrom
smnschndr:Fix-source-and-destination-adress-parsing
Jun 3, 2026
Merged

[cisco_asa] Fix source and destination address parsing#19218
bhapas merged 1 commit into
elastic:mainfrom
smnschndr:Fix-source-and-destination-adress-parsing

Conversation

@smnschndr
Copy link
Copy Markdown
Contributor

Summary

Fix source and destination address parsing by changing the Grok pattern for parse_750002 and parse_750003 from IP to IPORHOST. Added several tests for each combination.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@smnschndr smnschndr requested a review from a team as a code owner May 26, 2026 14:36
@smnschndr smnschndr force-pushed the Fix-source-and-destination-adress-parsing branch from 82ca458 to f2318ef Compare May 26, 2026 14:36
@smnschndr smnschndr force-pushed the Fix-source-and-destination-adress-parsing branch from f2318ef to ea6d372 Compare May 26, 2026 14:37
Copy link
Copy Markdown
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh added Integration:cisco_asa Cisco ASA Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels May 26, 2026
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

@bhapas
Copy link
Copy Markdown
Contributor

bhapas commented Jun 1, 2026

/test

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

@bhapas bhapas merged commit eeee8ac into elastic:main Jun 3, 2026
2 of 4 checks passed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package cisco_asa - 2.45.7 containing this change is available at https://epr.elastic.co/package/cisco_asa/2.45.7/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:cisco_asa Cisco ASA Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants