Change page_size and batch_size manifest variable type from text to integer - part 2#19253
Conversation
…nteger - part 2 Several integrations declare page_size or batch_size manifest variables with type: text when the value is always a positive integer. Fleet performs no numeric validation on text fields, so a user can set these to arbitrary strings. Changing to type: integer ensures Fleet rejects non-numeric input. Relates elastic#19248 [git-generate] for pkg in dataminr_pulse elastic_security google_workspace menlo microsoft_defender_endpoint microsoft_exchange_online_message_trace microsoft_sentinel; do find "packages/$pkg/" -type f -name manifest.yml \ -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} + done for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do ( cd "$pkg" elastic-package changelog add \ --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \ --type bugfix --next patch \ --link "elastic#19253" ) done
b91b419 to
95e3219
Compare
Elastic Docs Style Checker (Vale)Summary: 1 warning, 7 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/google_workspace/data_stream/alert/manifest.yml | 23 | Elastic.DontUse | Don't use 'Please'. |
💡 Suggestions (7): Optional style improvements. Apply when helpful.
| File | Line | Rule | Message |
|---|---|---|---|
| packages/elastic_security/changelog.yml | 1 | Elastic.Versions | Use 'later versions' instead of 'newer versions' when referring to versions. |
| packages/google_workspace/changelog.yml | 1 | Elastic.Versions | Use 'later versions' instead of 'newer versions' when referring to versions. |
| packages/menlo/changelog.yml | 1 | Elastic.Versions | Use 'later versions' instead of 'newer versions' when referring to versions. |
| packages/microsoft_defender_endpoint/changelog.yml | 1 | Elastic.Versions | Use 'later versions' instead of 'newer versions' when referring to versions. |
| packages/microsoft_defender_endpoint/changelog.yml | 9 | Elastic.Wordiness | Consider using 'remove' instead of 'eliminate'. |
| packages/microsoft_exchange_online_message_trace/changelog.yml | 1 | Elastic.Versions | Use 'later versions' instead of 'newer versions' when referring to versions. |
| packages/microsoft_sentinel/changelog.yml | 1 | Elastic.Versions | Use 'later versions' instead of 'newer versions' when referring to versions. |
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
💚 Build Succeeded
cc @kcreddy |
|
Package dataminr_pulse - 0.2.1 containing this change is available at https://epr.elastic.co/package/dataminr_pulse/0.2.1/ |
|
Package elastic_security - 0.4.1 containing this change is available at https://epr.elastic.co/package/elastic_security/0.4.1/ |
|
Package google_workspace - 3.3.3 containing this change is available at https://epr.elastic.co/package/google_workspace/3.3.3/ |
|
Package menlo - 1.7.2 containing this change is available at https://epr.elastic.co/package/menlo/1.7.2/ |
|
Package microsoft_defender_endpoint - 4.7.1 containing this change is available at https://epr.elastic.co/package/microsoft_defender_endpoint/4.7.1/ |
|
Package microsoft_exchange_online_message_trace - 2.1.1 containing this change is available at https://epr.elastic.co/package/microsoft_exchange_online_message_trace/2.1.1/ |
|
Package microsoft_sentinel - 1.3.2 containing this change is available at https://epr.elastic.co/package/microsoft_sentinel/1.3.2/ |
Proposed commit message
Checklist
changelog.ymlfile.Related issues
type: text#19248