Skip to content

Change page_size and batch_size manifest variable type from text to integer - part 2#19253

Merged
kcreddy merged 1 commit into
elastic:mainfrom
kcreddy:fix-batch-page-sizes-type-2
May 29, 2026
Merged

Change page_size and batch_size manifest variable type from text to integer - part 2#19253
kcreddy merged 1 commit into
elastic:mainfrom
kcreddy:fix-batch-page-sizes-type-2

Conversation

@kcreddy
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy commented May 28, 2026

Proposed commit message

Change page_size and batch_size manifest variable type from text to integer - part 2

Several integrations declare page_size or batch_size manifest variables
with type: text when the value is always a positive integer. Fleet
performs no numeric validation on text fields, so a user can set these
to arbitrary strings. Changing to type: integer ensures Fleet rejects
non-numeric input.

Relates https://github.com/elastic/integrations/issues/19248

[git-generate]
for pkg in dataminr_pulse elastic_security google_workspace menlo microsoft_defender_endpoint microsoft_exchange_online_message_trace microsoft_sentinel; do
  find "packages/$pkg/" -type f -name manifest.yml \
    -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} +
done
for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do
  (
    cd "$pkg"
    elastic-package changelog add \
      --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \
      --type bugfix --next patch \
      --link "https://github.com/elastic/integrations/pull/19253"
  )
done

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

…nteger - part 2

Several integrations declare page_size or batch_size manifest variables
with type: text when the value is always a positive integer. Fleet
performs no numeric validation on text fields, so a user can set these
to arbitrary strings. Changing to type: integer ensures Fleet rejects
non-numeric input.

Relates elastic#19248

[git-generate]
for pkg in dataminr_pulse elastic_security google_workspace menlo microsoft_defender_endpoint microsoft_exchange_online_message_trace microsoft_sentinel; do
  find "packages/$pkg/" -type f -name manifest.yml \
    -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} +
done
for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do
  (
    cd "$pkg"
    elastic-package changelog add \
      --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \
      --type bugfix --next patch \
      --link "elastic#19253"
  )
done
@kcreddy kcreddy force-pushed the fix-batch-page-sizes-type-2 branch from b91b419 to 95e3219 Compare May 28, 2026 08:39
@kcreddy kcreddy self-assigned this May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Elastic Docs Style Checker (Vale)

Summary: 1 warning, 7 suggestions found

⚠️ Warnings (1): Fix when the suggestion improves clarity or correctness.
File Line Rule Message
packages/google_workspace/data_stream/alert/manifest.yml 23 Elastic.DontUse Don't use 'Please'.
💡 Suggestions (7): Optional style improvements. Apply when helpful.
File Line Rule Message
packages/elastic_security/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/google_workspace/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/menlo/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/microsoft_defender_endpoint/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/microsoft_defender_endpoint/changelog.yml 9 Elastic.Wordiness Consider using 'remove' instead of 'eliminate'.
packages/microsoft_exchange_online_message_trace/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/microsoft_sentinel/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@kcreddy kcreddy marked this pull request as ready for review May 28, 2026 08:47
@kcreddy kcreddy requested review from a team as code owners May 28, 2026 08:47
@kcreddy kcreddy added Integration:google_workspace Google Workspace Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:menlo Menlo Security Integration:elastic_security Elastic Security Integration:dataminr_pulse Dataminr Pulse labels May 28, 2026
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy added the Integration:microsoft_sentinel Microsoft Sentinel label May 28, 2026
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

cc @kcreddy

@kcreddy kcreddy merged commit da61b7c into elastic:main May 29, 2026
9 checks passed
@kcreddy kcreddy deleted the fix-batch-page-sizes-type-2 branch May 29, 2026 03:11
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package dataminr_pulse - 0.2.1 containing this change is available at https://epr.elastic.co/package/dataminr_pulse/0.2.1/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package elastic_security - 0.4.1 containing this change is available at https://epr.elastic.co/package/elastic_security/0.4.1/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package google_workspace - 3.3.3 containing this change is available at https://epr.elastic.co/package/google_workspace/3.3.3/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package menlo - 1.7.2 containing this change is available at https://epr.elastic.co/package/menlo/1.7.2/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package microsoft_defender_endpoint - 4.7.1 containing this change is available at https://epr.elastic.co/package/microsoft_defender_endpoint/4.7.1/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package microsoft_exchange_online_message_trace - 2.1.1 containing this change is available at https://epr.elastic.co/package/microsoft_exchange_online_message_trace/2.1.1/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package microsoft_sentinel - 1.3.2 containing this change is available at https://epr.elastic.co/package/microsoft_sentinel/1.3.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:dataminr_pulse Dataminr Pulse Integration:elastic_security Elastic Security Integration:google_workspace Google Workspace Integration:menlo Menlo Security Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace Integration:microsoft_sentinel Microsoft Sentinel Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants