Skip to content

Change page_size and batch_size manifest variable type from text to integer - part 3#19257

Merged
kcreddy merged 1 commit into
elastic:mainfrom
kcreddy:fix-batch-page-sizes-type-3
May 29, 2026
Merged

Change page_size and batch_size manifest variable type from text to integer - part 3#19257
kcreddy merged 1 commit into
elastic:mainfrom
kcreddy:fix-batch-page-sizes-type-3

Conversation

@kcreddy
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy commented May 28, 2026

Proposed commit message

Change page_size and batch_size manifest variable type from text to integer - part 3

Several integrations declare page_size or batch_size manifest variables
with type: text when the value is always a positive integer. Fleet
performs no numeric validation on text fields, so a user can set these
to arbitrary strings. Changing to type: integer ensures Fleet rejects
non-numeric input.

Relates https://github.com/elastic/integrations/issues/19248

[git-generate]
for pkg in servicenow splunk sublime_security tenable_sc ti_greynoise ti_recordedfuture trend_micro_vision_one; do
  find "packages/$pkg/" -type f -name manifest.yml \
    -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} +
done
for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do
  (
    cd "$pkg"
    elastic-package changelog add \
      --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \
      --type bugfix --next patch \
      --link "https://github.com/elastic/integrations/pull/19257"
  )
done

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

kcreddy added a commit to kcreddy/integrations that referenced this pull request May 28, 2026
…nteger - part 3

Several integrations declare page_size or batch_size manifest variables
with type: text when the value is always a positive integer. Fleet
performs no numeric validation on text fields, so a user can set these
to arbitrary strings. Changing to type: integer ensures Fleet rejects
non-numeric input.

Relates elastic#19248

[git-generate]
for pkg in servicenow splunk sublime_security tenable_sc ti_greynoise ti_recordedfuture trend_micro_vision_one; do
  find "packages/$pkg/" -type f -name manifest.yml \
    -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} +
done
for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do
  (
    cd "$pkg"
    elastic-package changelog add \
      --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \
      --type bugfix --next patch \
      --link "elastic#19257"
  )
done
@kcreddy kcreddy force-pushed the fix-batch-page-sizes-type-3 branch from ec9b416 to 7dcfacc Compare May 28, 2026 08:52
@kcreddy kcreddy marked this pull request as ready for review May 28, 2026 08:53
@kcreddy kcreddy requested review from a team as code owners May 28, 2026 08:53
@kcreddy kcreddy self-assigned this May 28, 2026
@kcreddy kcreddy added Integration:tenable_sc Tenable Security Center Integration:ti_recordedfuture Recorded Future Integration:trend_micro_vision_one TrendAI Vision One bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:sublime_security Sublime Security Integration:servicenow ServiceNow Integration:splunk Splunk Integration:ti_greynoise GreyNoise (Community supported) labels May 28, 2026
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy added a commit to kcreddy/integrations that referenced this pull request May 28, 2026
…nteger - part 3

Several integrations declare page_size or batch_size manifest variables
with type: text when the value is always a positive integer. Fleet
performs no numeric validation on text fields, so a user can set these
to arbitrary strings. Changing to type: integer ensures Fleet rejects
non-numeric input.

Relates elastic#19248

[git-generate]
for pkg in servicenow splunk sublime_security tenable_sc ti_greynoise ti_recordedfuture; do
  find "packages/$pkg/" -type f -name manifest.yml \
    -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} +
done
for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do
  (
    cd "$pkg"
    elastic-package changelog add \
      --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \
      --type bugfix --next patch \
      --link "elastic#19257"
  )
done
@kcreddy kcreddy force-pushed the fix-batch-page-sizes-type-3 branch from 7dcfacc to e885cc6 Compare May 28, 2026 10:17
@kcreddy kcreddy removed the Integration:trend_micro_vision_one TrendAI Vision One label May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Elastic Docs Style Checker (Vale)

Summary: 11 suggestions found

💡 Suggestions (11): Optional style improvements. Apply when helpful.
File Line Rule Message
packages/servicenow/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/servicenow/changelog.yml 9 Elastic.Wordiness Consider using 'remove' instead of 'eliminate'.
packages/splunk/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/sublime_security/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/tenable_sc/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/tenable_sc/manifest.yml 4 Elastic.Wordiness Consider using 'to' instead of 'in order to'.
packages/ti_greynoise/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/ti_recordedfuture/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/trend_micro_vision_one/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.
packages/trend_micro_vision_one/changelog.yml 83 Elastic.WordChoice Consider using 'deactivate, deselect, hide, turn off' instead of 'Disable', unless the term is in the UI.
packages/trend_micro_vision_one/changelog.yml 83 Elastic.Wordiness Consider using 'before' instead of 'prior to'.

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

…nteger - part 3

Several integrations declare page_size or batch_size manifest variables
with type: text when the value is always a positive integer. Fleet
performs no numeric validation on text fields, so a user can set these
to arbitrary strings. Changing to type: integer ensures Fleet rejects
non-numeric input.

Relates elastic#19248

[git-generate]
for pkg in servicenow splunk sublime_security tenable_sc ti_greynoise ti_recordedfuture trend_micro_vision_one; do
  find "packages/$pkg/" -type f -name manifest.yml \
    -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} +
done
for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do
  (
    cd "$pkg"
    elastic-package changelog add \
      --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \
      --type bugfix --next patch \
      --link "elastic#19257"
  )
done
@kcreddy kcreddy force-pushed the fix-batch-page-sizes-type-3 branch from e885cc6 to 13003ed Compare May 28, 2026 12:22
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @kcreddy

@kcreddy kcreddy merged commit f8aa458 into elastic:main May 29, 2026
9 checks passed
@kcreddy kcreddy deleted the fix-batch-page-sizes-type-3 branch May 29, 2026 03:12
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package servicenow - 2.0.1 containing this change is available at https://epr.elastic.co/package/servicenow/2.0.1/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package splunk - 1.0.2 containing this change is available at https://epr.elastic.co/package/splunk/1.0.2/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package sublime_security - 1.11.3 containing this change is available at https://epr.elastic.co/package/sublime_security/1.11.3/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package tenable_sc - 2.2.1 containing this change is available at https://epr.elastic.co/package/tenable_sc/2.2.1/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package ti_greynoise - 0.8.1 containing this change is available at https://epr.elastic.co/package/ti_greynoise/0.8.1/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package ti_recordedfuture - 2.5.2 containing this change is available at https://epr.elastic.co/package/ti_recordedfuture/2.5.2/

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package trend_micro_vision_one - 2.12.1 containing this change is available at https://epr.elastic.co/package/trend_micro_vision_one/2.12.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:servicenow ServiceNow Integration:splunk Splunk Integration:sublime_security Sublime Security Integration:tenable_sc Tenable Security Center Integration:ti_greynoise GreyNoise (Community supported) Integration:ti_recordedfuture Recorded Future Integration:trend_micro_vision_one TrendAI Vision One Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants