Change page_size and batch_size manifest variable type from text to integer - part 3#19257
Conversation
…nteger - part 3 Several integrations declare page_size or batch_size manifest variables with type: text when the value is always a positive integer. Fleet performs no numeric validation on text fields, so a user can set these to arbitrary strings. Changing to type: integer ensures Fleet rejects non-numeric input. Relates elastic#19248 [git-generate] for pkg in servicenow splunk sublime_security tenable_sc ti_greynoise ti_recordedfuture trend_micro_vision_one; do find "packages/$pkg/" -type f -name manifest.yml \ -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} + done for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do ( cd "$pkg" elastic-package changelog add \ --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \ --type bugfix --next patch \ --link "elastic#19257" ) done
ec9b416 to
7dcfacc
Compare
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
…nteger - part 3 Several integrations declare page_size or batch_size manifest variables with type: text when the value is always a positive integer. Fleet performs no numeric validation on text fields, so a user can set these to arbitrary strings. Changing to type: integer ensures Fleet rejects non-numeric input. Relates elastic#19248 [git-generate] for pkg in servicenow splunk sublime_security tenable_sc ti_greynoise ti_recordedfuture; do find "packages/$pkg/" -type f -name manifest.yml \ -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} + done for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do ( cd "$pkg" elastic-package changelog add \ --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \ --type bugfix --next patch \ --link "elastic#19257" ) done
7dcfacc to
e885cc6
Compare
Elastic Docs Style Checker (Vale)Summary: 11 suggestions found 💡 Suggestions (11): Optional style improvements. Apply when helpful.
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
…nteger - part 3 Several integrations declare page_size or batch_size manifest variables with type: text when the value is always a positive integer. Fleet performs no numeric validation on text fields, so a user can set these to arbitrary strings. Changing to type: integer ensures Fleet rejects non-numeric input. Relates elastic#19248 [git-generate] for pkg in servicenow splunk sublime_security tenable_sc ti_greynoise ti_recordedfuture trend_micro_vision_one; do find "packages/$pkg/" -type f -name manifest.yml \ -exec perl -i -0pe 's/(name: (?:page_size|batch_size)\n\s+)type: text/$1type: integer/g' {} + done for pkg in $(git diff --name-only packages/ | cut -d/ -f1,2 | sort -u); do ( cd "$pkg" elastic-package changelog add \ --description "Change page_size/batch_size variable type from text to integer for Fleet input validation." \ --type bugfix --next patch \ --link "elastic#19257" ) done
e885cc6 to
13003ed
Compare
💚 Build Succeeded
History
cc @kcreddy |
|
Package servicenow - 2.0.1 containing this change is available at https://epr.elastic.co/package/servicenow/2.0.1/ |
|
Package splunk - 1.0.2 containing this change is available at https://epr.elastic.co/package/splunk/1.0.2/ |
|
Package sublime_security - 1.11.3 containing this change is available at https://epr.elastic.co/package/sublime_security/1.11.3/ |
|
Package tenable_sc - 2.2.1 containing this change is available at https://epr.elastic.co/package/tenable_sc/2.2.1/ |
|
Package ti_greynoise - 0.8.1 containing this change is available at https://epr.elastic.co/package/ti_greynoise/0.8.1/ |
|
Package ti_recordedfuture - 2.5.2 containing this change is available at https://epr.elastic.co/package/ti_recordedfuture/2.5.2/ |
|
Package trend_micro_vision_one - 2.12.1 containing this change is available at https://epr.elastic.co/package/trend_micro_vision_one/2.12.1/ |
Proposed commit message
Checklist
changelog.ymlfile.Related issues
type: text#19248