Skip to content

Conversation

@mtojek
Copy link
Contributor

@mtojek mtojek commented May 27, 2020

I found the following issues while testing:

  • wrong input type (should be redis)
  • rename Kibana search file (filename differs from the ID inside)

@mtojek mtojek requested a review from ruflin May 27, 2020 09:49
@mtojek mtojek self-assigned this May 27, 2020
@elasticmachine
Copy link

elasticmachine commented May 27, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #27 updated]

  • Start Time: 2020-05-27T11:52:54.372+0000

  • Duration: 5 min 51 sec

@ruflin
Copy link
Contributor

ruflin commented May 27, 2020

I assume this will also need an adjustement in the dataset manifest? https://github.com/elastic/integrations/blob/master/dev/packages/alpha/redis/0.1.0/dataset/slowlog/manifest.yml#L5

- type: logs
title: Collect logs from Redis instances
description: Collecting Redis log and slowlog logs
title: Collect application logs from Redis instances
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would expect the description to be the long version not the title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased.

@mtojek mtojek merged commit 2da4975 into elastic:master May 27, 2020
tomsonpl added a commit that referenced this pull request Dec 2, 2025
Documents new process listing artifact (#27) with 6 queries:
- 27: Process listing (Windows)
- 27a: Process listing (Linux)
- 27b: Process listing (macOS)
- 27c: Suspicious processes (Windows)
- 27d: Suspicious processes (Linux)
- 27e: Suspicious processes (macOS)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants