Skip to content

Conversation

@Supplementing
Copy link
Contributor

@Supplementing Supplementing commented Apr 22, 2025

Summary

Closes #193387

  • Adds expand functionality when editing the YML on a package policy.
Screen.Recording.2025-04-23.at.8.38.07.AM.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

N/A

@Supplementing Supplementing requested a review from a team as a code owner April 22, 2025 16:11
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 22, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@Supplementing Supplementing added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Apr 22, 2025
@Supplementing
Copy link
Contributor Author

@elasticmachine merge upstream

@Supplementing Supplementing enabled auto-merge (squash) April 22, 2025 16:16
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the kbn-code-editor plugin I see allowFullScreen as a prop here:

https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/shared-ux/code_editor/impl/code_editor.tsx#L134

Does providing that simplify this implementation, or does it not work how I'm expecting?

@Supplementing Supplementing requested a review from kpollich April 22, 2025 21:10
@Supplementing Supplementing disabled auto-merge April 23, 2025 00:26
@Supplementing Supplementing force-pushed the enhancement-expand-yml-editor branch from 5514aa5 to 5178247 Compare April 23, 2025 14:34
@Supplementing
Copy link
Contributor Author

@elasticmachine merge upstream

@Supplementing Supplementing enabled auto-merge (squash) April 23, 2025 14:42
@nchaulet nchaulet self-requested a review April 24, 2025 15:27
@Supplementing Supplementing merged commit 4f32ae6 into elastic:main Apr 24, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Fleet Cypress Tests #1 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +253.0B

History

akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
…lastic#218847)

## Summary

Closes elastic#193387 

- Adds expand functionality when editing the YML on a package policy.


https://github.com/user-attachments/assets/f2541766-8d4f-4a11-a117-fc8e7722827e

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

N/A

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet] Support expanding YML fields in integration policy editor

5 participants