Skip to content

Conversation

@xrmx
Copy link
Member

@xrmx xrmx commented Jun 13, 2025

Summary

Enable logging_level agent configuration options for EDOT Python (opentelemetry/python/elastic), PHP (opentelemetry/php/elastic) and .net (opentelemetry/dotnet/elastic).

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

  • I don't think this introduces any risk

@xrmx xrmx self-assigned this Jun 13, 2025
@xrmx xrmx requested review from a team as code owners June 13, 2025 15:55
@botelastic botelastic bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Jun 13, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@xrmx xrmx force-pushed the edot-python-apm-logging-level branch from 03e10d4 to 1dd6e55 Compare June 13, 2025 15:56
@xrmx xrmx added backport:current-major release_note:skip Skip the PR/issue when compiling release notes labels Jun 13, 2025
@xrmx xrmx force-pushed the edot-python-apm-logging-level branch from a98e3a8 to 62cac33 Compare June 16, 2025 07:40
@xrmx xrmx added backport:version Backport to applied version labels v9.1.0 v8.19.0 and removed backport:current-major labels Jun 17, 2025
@xrmx
Copy link
Member Author

xrmx commented Jun 17, 2025

I guess this will need #224160 for a proper 8.19 backport

@xrmx xrmx removed the v8.19.0 label Jun 17, 2025
@xrmx xrmx changed the title [APM] Enable logging_level agent configuration for EDOT Python [APM] Enable logging_level agent configuration for EDOT Python, PHP and .net Jun 17, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.6MB 2.6MB +270.0B

History

cc @xrmx

@trentm
Copy link
Member

trentm commented Jun 17, 2025

@tonyghiani Are you able to take a look at this one sometime? This is the same as the recent #222883 but for a few more of the EDOT SDK languages.

We (the Application Agents team) are attempting to get this and a subsequent PR for APM agent Central Config support in by the 9.1 freeze date.

@xrmx xrmx added v8.19.0 and removed v8.19.0 labels Jun 17, 2025
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additions to the agent names LGTM 👌

Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xrmx xrmx merged commit 8572e3d into elastic:main Jun 18, 2025
14 checks passed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 20, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 223947 locally
cc: @xrmx

3 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 223947 locally
cc: @xrmx

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 223947 locally
cc: @xrmx

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 223947 locally
cc: @xrmx

@xrmx xrmx added backport:skip This PR does not require backporting labels Jun 26, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants