-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[8.19] [Scout] update configs discovery based on .meta info (#245657) #246758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,063
−536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR updates how playwright configs are discovered and grouped for execution: - use scout manifest files to filter configs for a run (Kibana CI, + ECH/MKI pipelines) (see elastic#245135) - update filtering to include configs with at least 1 test to run (`expectedStatus` to be `passed`) - provide 2 formats for Kibana CI and ECH/MKI (use `--flatten` flag) pipelines to handle both cases efficiently - use `runModes` to simplify execution script `.buildkite/scripts/steps/test/scout_configs.sh` ### Usage: #### For regular Kibana CI (existing functionality) we run all the configs with at least 1 unskipped test ``` node scripts/scout discover-playwright-configs --save [ { "name": "kbn-streamlang-tests", "group": "platform", "type": "package", "configs": [ { "path": "x-pack/platform/packages/shared/kbn-streamlang-tests/test/scout/api/playwright.config.ts", "hasTests": true, "tags": [ "@ess", "@svlOblt" ], "serverRunFlags": [ "--stateful", "--serverless=oblt" ], "usesParallelWorkers": false } ] }, { "name": "discover_enhanced", "group": "platform", "type": "plugin", "configs": [ { "path": "x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts", "hasTests": true, "tags": [ "@ess", "@svlSearch", "@svlOblt", "@svlSecurity", "@svlSecurityEssentials", "@svlSecurityEase", "@svlLogsEssentials" ], "serverRunFlags": [ "--stateful", "--serverless=es", "--serverless=security", "--serverless=oblt" ], "usesParallelWorkers": true }, { "path": "x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/playwright.config.ts", "hasTests": true, "tags": [ ... ], "serverRunFlags": [ ... ], "usesParallelWorkers": false } ] }, ... ] ``` #### For MKI we filter only configs matching serverless projects, filter for non-empty ones and flatten structure to have multiple configs as a single track (those that can be run together) ``` node scripts/scout discover-playwright-configs --save --target mki --flatten [ { "mode": "serverless", "deploymentType": "observability", "group": "observability", "scoutCommand": "node scripts/scout run-tests --serverless=oblt --testTarget=cloud", "configs": [ "x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts", "x-pack/solutions/observability/plugins/infra/test/scout/ui/parallel.playwright.config.ts", "x-pack/solutions/observability/plugins/observability/test/scout/ui/playwright.config.ts", "x-pack/solutions/observability/plugins/observability_onboarding/test/scout/ui/playwright.config.ts", "x-pack/solutions/observability/plugins/slo/test/scout/ui/playwright.config.ts" ] }, { "mode": "serverless", "deploymentType": "elasticsearch", "group": "platform", "scoutCommand": "node scripts/scout run-tests --serverless=es --testTarget=cloud", "configs": [ "x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts", "x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/playwright.config.ts", "x-pack/platform/plugins/private/painless_lab/test/scout/api/playwright.config.ts", "x-pack/platform/plugins/shared/maps/test/scout/ui/playwright.config.ts", "src/platform/plugins/shared/console/test/scout/api/playwright.config.ts", "src/platform/plugins/shared/workflows_extensions/test/scout/api/playwright.config.ts" ] }, ... ] ``` ~~blocked by elastic#245135 --------- Co-authored-by: David Olaru <dolaru@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Cesare de Cal <cesare.decal@elastic.co> (cherry picked from commit 3862020) # Conflicts: # .buildkite/pipeline-utils/scout/pick_scout_test_group_run_order.ts # .buildkite/scripts/steps/test/scout_configs.sh # src/platform/packages/shared/kbn-scout/moon.yml # src/platform/packages/shared/kbn-scout/src/cli/config_discovery.ts # src/platform/packages/shared/kbn-scout/src/servers/configs/discovery/search_configs.ts # src/platform/packages/shared/kbn-scout/tsconfig.json
fake-haris
approved these changes
Dec 17, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation