[6.8][ML] Better interrupt handling during named pipe connection #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes two related issues with named pipe connection when the controller process first starts up: 1. If the ES JVM dies before the controller connects its logging named pipe then since elastic/elasticsearch#56491 the resulting errors from the controller process will be seen in the ES stderr file. There is a change to the logging to make it clearer that the controller didn't fail, but exited due to the ES JVM disappearing. 2. Interrupted system calls while connecting the named pipes could cause the pipes to unnecessarily fail to connect. There is a change to retry the calls on getting an EINTR error unless the interrupt was caused by the functionality of controller that kills off the connection attempts if the ES JVM dies (i.e. the scenario described in point 1). Backport of elastic#1311
added 4 commits
June 17, 2020 18:16
This reverts commit b027c43.
Due to Visual Studio 2013 crapness...
droberts195
deleted the
better_eintr_handling_in_named_pipe_connection_68
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes two related issues with named pipe connection
when the controller process first starts up:
named pipe then since Prevent unexpected native controller output hanging the process elasticsearch#56491 the resulting
errors from the controller process will be seen in the ES
stderr file. There is a change to the logging to make it
clearer that the controller didn't fail, but exited due to
the ES JVM disappearing.
could cause the pipes to unnecessarily fail to connect. There
is a change to retry the calls on getting an EINTR error unless
the interrupt was caused by the functionality of controller
that kills off the connection attempts if the ES JVM dies (i.e.
the scenario described in point 1).
Backport of #1311