Merged
Conversation
Contributor
Author
|
buildkite build this |
edsavage
changed the title
* Move business logic of 3rd party dependency builder to ml-cpp repo * Patch set_env.bat
Mention running the new `build_windows_third_party_deps.ps1` PowerShell script to automate building 3rd party dependencies.
|
valeriy42
approved these changes
Nov 5, 2024
Contributor
There was a problem hiding this comment.
LGTM. Good work 🚀
Only one thing: Would you mind bumping the CMake version to 3.30.5? I know I put 3.27.9 in the issue initially, but since then I discovered that at least on Linux there is no real reason not to use the latest Cmake version. Since there were several improvements regarding build speed and parallel efficiency, it would be good to benefit from them.
This was referenced Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the build system to use the Windows 2022 build VM.
The Windows 2022 build VM is provisioned with the Windows 11 SDK, build 22621 - https://developer.microsoft.com/en-us/windows/downloads/windows-sdk/