[ML] Fix Slack notification in version bump pipeline#3023
Merged
edsavage merged 2 commits intoelastic:mainfrom Apr 13, 2026
Merged
[ML] Fix Slack notification in version bump pipeline#3023edsavage merged 2 commits intoelastic:mainfrom
edsavage merged 2 commits intoelastic:mainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
edsavage
force-pushed
the
fix/version-bump-slack-notification
branch
from
08375d3 to
b7adce3
Compare
The top-level notify block in dynamically uploaded pipelines doesn't fire reliably for build-level state changes. Replace it with the same two-stage sub-pipeline pattern used by the other ml-cpp pipelines. Adds a dedicated send_version_bump_notification.sh that includes notify blocks for both: - build.state == "blocked" — tells the team the pipeline needs unblocking (the original purpose of the notification) - build.state == "passed" || "failed" — standard completion notification Made-with: Cursor
edsavage
force-pushed
the
fix/version-bump-slack-notification
branch
from
b7adce3 to
d9efd02
Compare
darius-vil
approved these changes
Apr 13, 2026
valeriy42
reviewed
Apr 13, 2026
| notify: | ||
| - slack: | ||
| channels: | ||
| - "#machine-learn-build" |
Contributor
There was a problem hiding this comment.
Can you please add #ml-core here?
valeriy42
approved these changes
Apr 13, 2026
Contributor
valeriy42
left a comment
valeriy42
left a comment
There was a problem hiding this comment.
LGTM. You minor comment.
ninalee12
approved these changes
Apr 13, 2026
Contributor
ninalee12
left a comment
ninalee12
left a comment
There was a problem hiding this comment.
LGTM
interesting that notifications didn't fire for all triggered instances
For successes and blocks I only saw these message:
Contributor
Author
Yeah, it was weirdly unreliable. I don't know exactly what the problem was TBH |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ml-cpp-version-bumppipeline never sent Slack notifications despite having anotifyblock configured.Root cause
The version bump pipeline generator (
job-version-bump.json.py) outputs a top-levelnotifyblock in its JSON. However, when this JSON is dynamically uploaded viabuildkite-agent pipeline upload, thenotifyblock doesn't fire reliably for build-level state changes.All other ml-cpp pipelines use a different pattern that works: they add a step that uploads a notification shell script as a sub-pipeline, which has its own
notifyblock.Fix
Replace the top-level
notifyblock with a step that uploads a dedicatedsend_version_bump_notification.shas a sub-pipeline. This script includes twonotifyblocks:build.state == "blocked"— notifies#machine-learn-buildthat the pipeline is waiting for approval (with version, branch, workflow details)build.state != "blocked"— notifies on any terminal state (pass, fail, cancel)Test results
Verified on builds #4 and #5:
#machine-learn-buildwhen build reaches blocked state#machine-learn-buildwhen build is cancelled