Skip to content

[enrichments]Allow overriding host name with k8s node name #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lahsivjar merged 1 commit into from
Oct 10, 2024
Merged

[enrichments]Allow overriding host name with k8s node name #108

lahsivjar merged 1 commit into from
Oct 10, 2024

Conversation

@lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented Oct 10, 2024 

// Host name is set same as k8s node name. In case, both host name
// and k8s node name are set then host name is overridden as this is
// considered an invalid configuration/smell and k8s node name is
// given higher preference.

For more context: https://elastic.slack.com/archives/C07Q1CVD9MW/p1728487638317189

@lahsivjar lahsivjar requested a review from a team as a code owner October 10, 2024 11:42
rogercoll
rogercoll approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lahsivjar lahsivjar merged commit c81f43f into elastic:main Oct 10, 2024
@lahsivjar lahsivjar deleted the hostname branch October 10, 2024 12:22
@rogercoll rogercoll mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rogercoll rogercoll rogercoll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lahsivjar @rogercoll