-
Notifications
You must be signed in to change notification settings - Fork 16
feat: add elasticsearch config and client #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
carsonip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm. Are you planning to make es exporter use this config and client?
The initial plan is to use it for a couple of extensions in Elastic's components repository, but yes, I will create an issue upstream to follow up on the exporter too. |
configelasticsearchpackage follows the same structure as upstream configuration packages:NewDefaultConfig+ToClientmethods.Usage (composed type so extra fields can be added):