Handle deployment.environment.name #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
reviewed
Mar 21, 2025
If `deployment.environment.name` is set, we duplicate it into `deployment.environment` in order to make the `service.environment` -> `deployment.environment` work.
gregkalapos
force-pushed
the
handle_deployment_environment_name
branch
from
db5633c to
2072617
Compare
Co-authored-by: Vishal Raj <vishal.raj@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployment.environment.namewas introduced in SemConv v1.27.0 anddeployment.environmentgot deprecated.In the
otel-dataES plugin we aliasservice.environmenttodeployment.environment.service.environmentis used by Kibana to show the environment.In this PR, if
deployment.environment.nameis set, we duplicate it intodeployment.environmentin order to make theservice.environment->deployment.environmentwork.So far there is no better solution on the table - ideally we'd need an ES feature where the
service.environmentalias has two targets, but currently that is not possible in ES.