Fix handling of non root span that represent a dependency #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Since this causes missing spans (as @lahsivjar assuming the PR is ok, could we push a release of this repo in the near future? Or maybe @rogercoll can help with that? |
lahsivjar
approved these changes
Apr 16, 2025
| // In such cases, the span is still mapped into a transaction, but enriched | ||
| // with additional attributes that are specific to the outgoing call or producer span. | ||
| isExitRootSpan := s.isTransaction && span.Kind() == ptrace.SpanKindClient || span.Kind() == ptrace.SpanKindProducer | ||
| isExitRootSpan := s.isTransaction && (span.Kind() == ptrace.SpanKindClient || span.Kind() == ptrace.SpanKindProducer) |
Contributor
There was a problem hiding this comment.
Thanks a lot for finding and fixing this.
Contributor
I can cut a new release, the dependabot should do the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression reported by @AlexanderWert.
Problem was missing
()when dependencies were calculated resulting in mapping a non-root span partly as a transaction and not settingprocessor.event.Also added a test covering such cases.