Skip to content

Add missing trusted PID checks in probes #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Add missing trusted PID checks in probes #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions elastic-ebpf/GPL/Events/File/Probe.bpf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,10 @@ int BPF_KPROBE(kprobe__chmod_common, const struct path *path, umode_t mode)
struct ebpf_events_state state = {};
state.chmod.path = (struct path *)path;
state.chmod.mode = mode;

if (ebpf_events_is_trusted_pid())
return 0;

ebpf_events_state__set(EBPF_EVENTS_STATE_CHMOD, &state);
return 0;
}
Expand Down Expand Up @@ -650,6 +654,9 @@ int BPF_KPROBE(kprobe__do_truncate)
{
struct ebpf_events_state state = {};

if (ebpf_events_is_trusted_pid())
goto out;

struct file *filp;
if (FUNC_ARG_READ_PTREGS(filp, do_truncate, filp)) {
bpf_printk("kprobe__do_truncate: error reading filp\n");
Expand Down Expand Up @@ -703,6 +710,8 @@ SEC("kprobe/vfs_write")
int BPF_KPROBE(kprobe__vfs_write, struct file *file)
{
struct ebpf_events_state state = {};
if (ebpf_events_is_trusted_pid())
return 0;

state.write.path = path_from_file(file);
ebpf_events_state__set(EBPF_EVENTS_STATE_WRITE, &state);
Expand All @@ -714,6 +723,8 @@ SEC("kprobe/vfs_writev")
int BPF_KPROBE(kprobe__vfs_writev, struct file *file)
{
struct ebpf_events_state state = {};
if (ebpf_events_is_trusted_pid())
return 0;

state.writev.path = path_from_file(file);
ebpf_events_state__set(EBPF_EVENTS_STATE_WRITEV, &state);
Expand Down Expand Up @@ -786,6 +797,8 @@ SEC("kprobe/chown_common")
int BPF_KPROBE(kprobe__chown_common, struct path *path, uid_t user, gid_t group)
{
struct ebpf_events_state state = {};
if (ebpf_events_is_trusted_pid())
return 0;
state.chown.path = path;
ebpf_events_state__set(EBPF_EVENTS_STATE_CHOWN, &state);
return 0;
Expand Down
3 changes: 3 additions & 0 deletions elastic-ebpf/GPL/Events/Network/Probe.bpf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,9 @@ int sk_maybe_save_tgid(struct bpf_sock *sk)
if (sk->protocol != IPPROTO_UDP)
return (1);

if (ebpf_events_is_trusted_pid())
return (1);

tgid = bpf_get_current_pid_tgid() >> 32;

/*
Expand Down