krun-ubuntu initial version

[stanek-michal]

needs review, arm64 not properly tested yet (getting ERANGE)

issue: #150

[haesbaert]

I did some testing and it works.

You can remove the arm64 support for now, the others don't support it yet, we can add all of them together as a second step.

Also please make sure to have the same command line order as krun-fedora.sh and krun-rhel.sh
I'm a bit nitpicky with "everything looking the same", this is the usage for the other one:

eru:quark: ./krun-fedora.sh
usage: krun-fedora.sh initramfs.gz FEDORAVERSION command

I'm fine with updating them all to be more verbose like the one here (usage should still be lower case though).

[haesbaert]

Also please make sure to have the same command line order as krun-fedora.sh and krun-rhel.sh I'm a bit nitpicky with "everything looking the same", this is the usage for the other one:

Uh now I realize the order is the same, if you remove the arch option, but that is too weird, an optional parameter in between two required ones, how about you move the arch to a -a amd64? with this we can also deal with the other ones later.

[haesbaert]

Some more points

• The temporary files are not deleted, they should
• Can you hide the [INFO] prints under a -v, we can add the same later on the other ones.
• Indentation should be tabs, not two spaces

[stanek-michal]

thanks for the review, I fixed whitespace, style, logs, usage, args, cleaning up tmp on success path, some other stuff

[haesbaert]

thanks for the review, I fixed whitespace, style, logs, usage, args, cleaning up tmp on success path, some other stuff

I've fixed some more things, basically made them a bit more similar to rhel/fedora, and added the tests to the CI, you can see on the build there.

I'm ok with the current state, if you're ok with it too, just squash it into a nice commit message (we're trying to do proper commit messages once they make it to the tree), and you can merge.

[stanek-michal]

Looks great, I squashed the commits. You can ACK and merge