Only attempt to probe ipv6 if present #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasberlin
force-pushed
the
probe_ipv6_only_when_present
branch
from
3c66b05 to
50e1a2c
Compare
haesbaert
reviewed
Jul 4, 2025
Collaborator
|
I'm approving this as I'll be off the whole week, feel free to change to a socket call or not. |
haesbaert
approved these changes
Jul 6, 2025
Collaborator
haesbaert
left a comment
haesbaert
left a comment
There was a problem hiding this comment.
the syntax on if (ipv6_supported()... needs fixing, otherwise fine.
Fix format Rework ipv6 detection to be more direct
Contributor
Author
|
Thanks for the review. I've tested this locally with a kernel built to load ipv6 as a module and the tests pass. Added an issue to figure out to add a kernel like this to CI: #202 |
Collaborator
|
Can I squash and merge this? |
Contributor
Author
yes, please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.