Skip to content

Conversation

@nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Apr 11, 2022

@nastasha-solomon
Copy link
Contributor Author

nastasha-solomon commented Apr 18, 2022

Reminder to self to change the square brackets ([ ]) to double angle brackets (<< >>) before merging this PR. The reference won't resolve until the "Session view" topic is merged into main and pulled into this branch. To ensure the HTML preview builds, I'm temporarily removing the reference to that topic.
cc: @benironside

@nastasha-solomon nastasha-solomon marked this pull request as ready for review April 18, 2022 21:15
@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2022

This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-1723-8.2.0-rn upstream/issue-1723-8.2.0-rn
git merge upstream/main
git push upstream issue-1723-8.2.0-rn

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, thanks!

Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 Thank you for the fixes @nastasha-solomon!

@muskangulati-qasource
Copy link

Hi @nastasha-solomon,

We are marking this issue as 'QA Validated' as both the issues are now fixed.

Thanks!

@muskangulati-qasource muskangulati-qasource added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Apr 25, 2022
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment -- you can add a link to the Users page once I merge the PR. Thanks!

Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small edits - thanks.

nastasha-solomon and others added 3 commits May 2, 2022 16:35
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
@nastasha-solomon nastasha-solomon merged commit a8a8419 into main May 2, 2022
@nastasha-solomon nastasha-solomon deleted the issue-1723-8.2.0-rn branch May 2, 2022 20:46
mergify bot pushed a commit that referenced this pull request May 2, 2022
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
(cherry picked from commit a8a8419)
nastasha-solomon added a commit that referenced this pull request May 2, 2022
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA:Validated Issue has been Validated by QA Team release-notes Team: Docs v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] 8.2.0 Release Notes

9 participants