Skip to content

Conversation

@joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Jun 6, 2022

@joepeeples joepeeples marked this pull request as ready for review June 6, 2022 20:47
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor suggestions, but overall LGTM!

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joepeeples and others added 2 commits June 7, 2022 14:02
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my feedback yesterday, so approving ✅

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for the update here @joepeeples 🙂

@joepeeples joepeeples merged commit dbd73b6 into main Jun 8, 2022
mergify bot pushed a commit that referenced this pull request Jun 8, 2022
* Update rule-execution-logs.png

* Add instructions for filter by rule execution

* Sharpen icon

* Update docs/detections/rules-ui-monitor.asciidoc

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Add mention of restoring previous filters

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit dbd73b6)
joepeeples added a commit that referenced this pull request Jun 8, 2022
…#2053)

* Update rule-execution-logs.png

* Add instructions for filter by rule execution

* Sharpen icon

* Update docs/detections/rules-ui-monitor.asciidoc

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Add mention of restoring previous filters

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit dbd73b6)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@joepeeples joepeeples deleted the issue-2043-rule-execution-logs-actions-filter branch June 8, 2022 19:58
@joepeeples joepeeples mentioned this pull request Jun 23, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] Rule execution logs: Add filter icon in Actions column

6 participants