Skip to content

Conversation

@joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Jun 20, 2022

@joepeeples joepeeples marked this pull request as ready for review June 20, 2022 15:05
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions. LGTM otherwise!

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a suggestion and a question.

@joepeeples joepeeples marked this pull request as draft June 22, 2022 20:12
@joepeeples joepeeples mentioned this pull request Jun 23, 2022
15 tasks
@joepeeples joepeeples marked this pull request as ready for review June 27, 2022 15:16
@joepeeples joepeeples requested a review from spong June 27, 2022 15:17
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits, but other than that these docs look great @joepeeples! They read really well, cover all the use cases, and make it easy to know what actionable steps the user needs to perform to ensure continued functionality. Thank you for working with @randomuserid and I to get these just right -- appreciate it! 🙂 LGTM!

joepeeples and others added 2 commits June 27, 2022 22:10
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some edits for your consideration. LGTM overall though and congrats on working through everything!

@randomuserid
Copy link

The smoothest workflow would be this;

  1. Upgrade the stack to 8.3
  2. Upgrade the agents and / or beats to 8.3
  3. Install the new rules
  4. Stop the v1 / v2 jobs and rules
  5. Start the v3 jobs
  6. Enable the new rules

In a case where mixed version fleets are running, such as a mix of 8.x and 7.x agents, the new and old (v1 / v2) jobs can be run in parallel - but this will tend to result in some duplicate alerts unless the jobs were modified. A version number filter could be added to the datafeed queries to ensure v3 jobs ingest events from 8.3 / 8.2 agents while v1 / v2 jobs ingest events from older agents.

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the updates. Nice work

joepeeples and others added 2 commits June 28, 2022 15:09
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
@joepeeples
Copy link
Contributor Author

joepeeples commented Jun 28, 2022

The smoothest workflow would be this;

  1. Upgrade the stack to 8.3
  2. Upgrade the agents and / or beats to 8.3
  3. Install the new rules
  4. Stop the v1 / v2 jobs and rules
  5. Start the v3 jobs
  6. Enable the new rules

In a case where mixed version fleets are running, such as a mix of 8.x and 7.x agents, the new and old (v1 / v2) jobs can be run in parallel - but this will tend to result in some duplicate alerts unless the jobs were modified. A version number filter could be added to the datafeed queries to ensure v3 jobs ingest events from 8.3 / 8.2 agents while v1 / v2 jobs ingest events from older agents.

Thanks, this is a helpful break-down, @randomuserid. I opened #2159 to document this upgrade path in the Post-upgrade steps section of the docs. That way we can get this PR's changes into the docs for the release, and start directing users to it from the docs links in the UI callout/modal. I'll follow up on the additional upgrade docs soon.

@joepeeples joepeeples merged commit b6de7bd into main Jun 28, 2022
mergify bot pushed a commit that referenced this pull request Jun 28, 2022
* Update rules-ui-monitor.asciidoc

* Small fixes

* Apply suggestions from Nastasha's review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Revised draft

* Minor edit

* Apply suggestions from Garrett's review

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
(cherry picked from commit b6de7bd)
joepeeples added a commit that referenced this pull request Jun 28, 2022
…2164)

* Update rules-ui-monitor.asciidoc

* Small fixes

* Apply suggestions from Nastasha's review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Revised draft

* Minor edit

* Apply suggestions from Garrett's review

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
(cherry picked from commit b6de7bd)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@joepeeples joepeeples deleted the issue-1748-ML-V3-modules branch June 28, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] Add documentation page for users upgrading to V3 ML Modules added in 8.2

6 participants