[DOCS] New grouped navigation side menu #2088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also slight reorder to better match UI
joepeeples
added
Team: Docs
Feature: New Navigation
joepeeples
requested review from
benironside,
jmikell821,
nastasha-solomon,
paulewing,
semd and
stephmilovic
joepeeples
changed the title
benironside
reviewed
Jun 22, 2022
Contributor
benironside
left a comment
benironside
left a comment
There was a problem hiding this comment.
Looks great! Left a few suggestions for your consideration.
Contributor
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
This looks great! Left some comments and questions for your consideration. Thanks!
Contributor
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
This looks great! Left some comments and questions for your consideration. Thanks!
Contributor
|
One more thing, pretty minor but I think the lower half of the screenshot on the new page could be cropped. |
|
we have validated the preview docs are all changes made are good to go and complete ✔️ . Fixed Areas: Hence we are adding "QA:Validated" tag to it. |
muskangulati-qasource
added
QA:Validated
joepeeples
commented
Jun 24, 2022
joepeeples
commented
Jun 24, 2022
joepeeples
commented
Jun 24, 2022
joepeeples
commented
Jun 24, 2022
Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
joepeeples
commented
Jun 24, 2022
jmikell821
reviewed
Jun 24, 2022
Contributor
jmikell821
left a comment
jmikell821
left a comment
There was a problem hiding this comment.
LGTM! Very small comments, thanks!
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Jun 26, 2022
* Add to Advanced Settings Also slight reorder to better match UI * Add new nested topic, images * Corrects name of advanced setting * Apply suggestions from code review Co-authored-by: benironside <91905639+benironside@users.noreply.github.com> * Update docs/getting-started/advanced-setting.asciidoc * Crop image * Update docs/getting-started/grouped-nav-ui.asciidoc * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> Co-authored-by: benironside <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 0274e14)
joepeeples
added a commit
that referenced
this pull request
Jun 26, 2022
* Add to Advanced Settings Also slight reorder to better match UI * Add new nested topic, images * Corrects name of advanced setting * Apply suggestions from code review Co-authored-by: benironside <91905639+benironside@users.noreply.github.com> * Update docs/getting-started/advanced-setting.asciidoc * Crop image * Update docs/getting-started/grouped-nav-ui.asciidoc * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> Co-authored-by: benironside <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 0274e14) Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2071.
Previews: