Skip to content

[DOCS] New option for users to run query packs from alert #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Aug 23, 2022
Merged

[DOCS] New option for users to run query packs from alert #2249

merged 25 commits into from
Aug 23, 2022

Conversation

@nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Aug 3, 2022 •
edited
Loading

Addresses #2231. Made the following changes to the topic:

  • Steps 2 and 4 describe the two query types users can choose from.
  • Step 5 includes a tip about the timeout period (not sure if this is correct, so please comment if it's not @patrykkopycinski :) )
  • Created new sections for reviewing and investigating query results.
  • Added a bit more information about the results tab to help users better understand the Results tab and results table.
  • Made minor revisions to the section about investigating query results. The instructions are more explicit and include images of the button icons.

Preview here.

@nastasha-solomon nastasha-solomon self-assigned this Aug 3, 2022
@nastasha-solomon nastasha-solomon changed the title [DOCS] New option for users to run a single query or run a pack [DOCS] New option for users to run query packs from alert Aug 4, 2022
james-elastic
james-elastic approved these changes Aug 10, 2022
View reviewed changes
Copy link

@james-elastic james-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nastasha-solomon nastasha-solomon marked this pull request as ready for review August 12, 2022 17:18
joepeeples
joepeeples reviewed Aug 12, 2022
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few line edits and questions, thanks!

Also, I love all the inline images but some are small and hard to make out. It looks like there's a lot of unnecessary white space around the icons, so is it possible to crop that out? I usually only leave a single pixel of padding, if any.

image vs. image

nastasha-solomon
nastasha-solomon commented Aug 16, 2022
View reviewed changes
@nastasha-solomon nastasha-solomon added the readyforQA PRs that are ready for QA review. label Aug 16, 2022
@arvindersingh-qasource
Copy link

arvindersingh-qasource commented Aug 17, 2022 •
edited
Loading

Hi @nastasha-solomon ,

We tested this PR and found 01 issue.

We will Re-validate this PR once the above issue is fixed.

Thanks!

@arvindersingh-qasource arvindersingh-qasource removed the readyforQA PRs that are ready for QA review. label Aug 17, 2022
@nastasha-solomon nastasha-solomon mentioned this pull request Aug 17, 2022
Closed
arvindersingh-qasource
arvindersingh-qasource approved these changes Aug 18, 2022
View reviewed changes
Copy link

@arvindersingh-qasource arvindersingh-qasource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nastasha-solomon

Thanks for all the updates.
We have revalidated the Kibana documentation with reference to this PR and found that issue is fixed

Issue Ticket

Thanks.

@arvindersingh-qasource arvindersingh-qasource added the QA:Validated Issue has been Validated by QA Team label Aug 18, 2022
benironside
benironside reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left a couple minor suggestions

nastasha-solomon and others added 2 commits August 18, 2022 14:39
@nastasha-solomon @benironside
Update docs/detections/alerts-run-osquery.asciidoc
5d319ae 
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@nastasha-solomon @benironside
Update docs/detections/alerts-run-osquery.asciidoc
ed855da 
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@nastasha-solomon nastasha-solomon mentioned this pull request Aug 18, 2022
Closed
20 tasks
jmikell821
jmikell821 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@nastasha-solomon
Copy link
Contributor Author

nastasha-solomon commented Aug 23, 2022

@elasticmachine run elasticsearch-ci/docs

@nastasha-solomon nastasha-solomon merged commit e5c781a into main Aug 23, 2022
@mergify mergify bot mentioned this pull request Aug 23, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 23, 2022
@nastasha-solomon @joepeeples
@benironside @mergify
[DOCS] New option for users to run query packs from alert (#2249)
ef76652 
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit e5c781a)
nastasha-solomon added a commit that referenced this pull request Aug 23, 2022
@mergify @joepeeples
@benironside @nastasha-solomon
[8.4] [DOCS] New option for users to run query packs from alert (back…
008b88d 
…port #2249) (#2355)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
@nastasha-solomon nastasha-solomon mentioned this pull request Aug 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benironside benironside benironside left review comments

@james-elastic james-elastic james-elastic approved these changes

@jmikell821 jmikell821 jmikell821 approved these changes

@arvindersingh-qasource arvindersingh-qasource arvindersingh-qasource approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

+1 more reviewer

@joepeeples joepeeples joepeeples left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nastasha-solomon nastasha-solomon

Labels

Feature: Osquery QA:Validated Issue has been Validated by QA Team Team: Docs v8.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nastasha-solomon @arvindersingh-qasource @james-elastic @jmikell821 @joepeeples @benironside