[DOCS] Advanced rule query preview option available #2251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastasha-solomon
added
Team: Docs
Team: Detections/Response
e40pud
reviewed
Aug 4, 2022
nastasha-solomon
requested review from
benironside,
jmikell821,
joepeeples and
marshallmain
Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>
joepeeples
approved these changes
Aug 16, 2022
Contributor
joepeeples
left a comment
joepeeples
left a comment
There was a problem hiding this comment.
LGTM! A couple very minor edit suggestions.
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
|
We have reviewed the shared preview link and observed that all changes are present 🟢 Screenshots:
Hence we are adding the "QA: Validated" label to it. Thanks!! |
ghost
added
QA:Validated
jmikell821
approved these changes
Aug 17, 2022
Contributor
jmikell821
left a comment
jmikell821
left a comment
There was a problem hiding this comment.
LGTM, thanks for getting this in! 👍
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> (cherry picked from commit 10fbdd2)
This was referenced Aug 18, 2022
nastasha-solomon
added a commit
to nastasha-solomon/security-docs
that referenced
this pull request
Sep 19, 2022
…lastic#2251) (elastic#2313) Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2227.
Preview here.