[DOCS] Import value lists: renamed button, new flyout UI #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepeeples
added
Team: Docs
Team: Detections/Response
Renamed button appears on Rules page
nastasha-solomon
approved these changes
Aug 12, 2022
Contributor
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
Looks great, thanks @joepeeples !
This comment was marked as resolved.
This comment was marked as resolved.
|
Hi @joepeeples, We tested this PR and found 01 issue. We will Re-validate this PR once the above issue is fixed. Thanks! |
ghost
removed
the
joepeeples
commented
Aug 17, 2022
security-docs#2310
Contributor
Author
|
Corrected in commit a7f5981. Thanks! |
|
Hi @joepeeples, We have reviewed the shared preview link and observed that all changes are present 🟢
Hence we are adding the "QA: Validated" label to it. Thanks!! |
This comment was marked as resolved.
This comment was marked as resolved.
joepeeples
commented
Aug 18, 2022
jmikell821
approved these changes
Aug 23, 2022
Contributor
jmikell821
left a comment
jmikell821
left a comment
There was a problem hiding this comment.
Quick and easy -- LGTM! 👍
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2022
* Update text * Update and resize screenshots * Update screenshots of Rules page Renamed button appears on Rules page * Correction (QA) security-docs#2310 * Trim cross-reference (cherry picked from commit c3a9494)
joepeeples
added a commit
that referenced
this pull request
Aug 23, 2022
* Update text * Update and resize screenshots * Update screenshots of Rules page Renamed button appears on Rules page * Correction (QA) security-docs#2310 * Trim cross-reference (cherry picked from commit c3a9494) Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2262.
Previews: