-
Notifications
You must be signed in to change notification settings - Fork 206
[DOCS] Changes to Alert details flyout and new Insights section #2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
janmonschke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
michaelolo24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome sauce! Thanks for updating this 😄
benironside
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left one minor suggestion
|
we have validated the docs preview and all the required changes are present and correct. ✔️ Snap-Shoot Hence we are adding "QA:Validated" tag to it. thanks !! |
jmikell821
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment. LGTM otherwise! 👍
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
|
@jmikell821 qq: are you saying it's ok to omit for/on in this sentence?
I do think it needs "for/on" because the sentence saying that the "Enriched data" section only displays when the alert being viewed has threat intel data. To use a general example, if a threat indicator match alert was generated, it should have threat intel data. Now, because it has threat intel data, the "Enriched data" section will show up on the Overview tab when you open the alert's details. If you removed "for/on" in the sentence, it would say the following, which is not correct:
Does this revision help clarify things at all?
|
|
@nastasha-solomon yes I'm OK with the revision.
|
Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 20c0674)

Addresses #2265.
Previews: