[DOCS] Alerts now shown in process tree #2309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastasha-solomon
added
Team: Docs
Team: Threat Hunting
kqualters-elastic
approved these changes
Aug 17, 2022
Contributor
kqualters-elastic
left a comment
kqualters-elastic
left a comment
There was a problem hiding this comment.
besides the 1 letter nitpick lgtm 👍
Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
kqualters-elastic
approved these changes
Aug 18, 2022
Contributor
kqualters-elastic
left a comment
kqualters-elastic
left a comment
There was a problem hiding this comment.
lgtm thanks for updating!
Contributor
Author
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
minor wording changes to align messaging with how it's written in other sec docs
20 tasks
|
We have reviewed the shared preview link and observed that all changes are present 🟢
Hence we are adding the "QA: Validated" label to it. Thanks!! |
ghost
removed
the
joepeeples
reviewed
Aug 22, 2022
Contributor
joepeeples
left a comment
joepeeples
left a comment
There was a problem hiding this comment.
Looks good! Added a small correction and a more optional suggestion.
jmikell821
reviewed
Aug 22, 2022
Contributor
jmikell821
left a comment
jmikell821
left a comment
There was a problem hiding this comment.
Just one comment/question. Thanks!
benironside
approved these changes
Aug 22, 2022
Contributor
benironside
left a comment
benironside
left a comment
There was a problem hiding this comment.
LGTM just left one super minor suggest
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2022
Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit cc2d8a5)
nastasha-solomon
added a commit
that referenced
this pull request
Aug 23, 2022
Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2264.
Preview here.