[DOCS] Creates stubs for new KSPM pages #2315
Conversation
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
I think all of this is fine. I'm not too familiar with this type of set-up though, so I'll let @joepeeples verify.
|
I think the links are OK, but the page locations might need a little reorganizing. As of #2289 we're renaming the "Manage" section to "Endpoint management," so that the overall section is no longer mirroring what's in the nav but just describing a general function around endpoints. It'd probably be better to have the "Benchmark rules" page in a separate main section that's all about cloud stuff, which I don't think we currently have but could create. So instead of adding that file as an include in |
Sounds good to add the Benchmark rules page to the Cloud Native Security section, thanks. That section is going to go under Detections and Alerts. |
joepeeples
left a comment
joepeeples
left a comment
There was a problem hiding this comment.
Structure looks good! Exciting to see new cloud features getting top billing in the docs.
| [[cloud-native-security-overview]] | ||
|
|
||
| = Cloud native security | ||
| Elastic’s cloud security capabilities help you to improve your Kubernetes security posture by comparing your configuration to best practices, and help you monitor and investigate your Linux deployments inside and outside of Kubernetes. This is an area of focus for Elastic Security, and you can expect many more cloud security features in future releases. |
There was a problem hiding this comment.
The second sentence sounds more like a blog or marketing statement, and even though it's pretty general we try to avoid forward-looking statements that seem to "promise" things.
I know the focus of this PR is more about structure than content, so we can do a closer review later if there's more to come for this section.
There was a problem hiding this comment.
I would definitely nix the second sentence.
jmikell821
left a comment
jmikell821
left a comment
There was a problem hiding this comment.
@benironside just one small comment piggybacking off what @joepeeples mentioned, otherwise LGTM!
| [[cloud-native-security-overview]] | ||
|
|
||
| = Cloud native security | ||
| Elastic’s cloud security capabilities help you to improve your Kubernetes security posture by comparing your configuration to best practices, and help you monitor and investigate your Linux deployments inside and outside of Kubernetes. This is an area of focus for Elastic Security, and you can expect many more cloud security features in future releases. |
There was a problem hiding this comment.
I would definitely nix the second sentence.
* Creates stubs for KSPM 8.4 docs to fix linking issues * Fix benchmark rules page title * Fixes build failures * Addresses Joe's feedback * Update cloud-native-security-index.asciidoc (cherry picked from commit 8a4ed8f)
* Creates stubs for KSPM 8.4 docs to fix linking issues * Fix benchmark rules page title * Fixes build failures * Addresses Joe's feedback * Update cloud-native-security-index.asciidoc (cherry picked from commit 8a4ed8f) Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Addresses #2260 by adding stub pages for the new KSPM docs to address broken link/build failure issues.