[DOCS][KSPM] Benchmark rules - new doc #2332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benironside
requested review from
jmikell821,
joepeeples,
nastasha-solomon and
tinnytintin10
joepeeples
reviewed
Aug 22, 2022
Contributor
joepeeples
left a comment
joepeeples
left a comment
There was a problem hiding this comment.
Solid content -- maybe add a general screenshot, if possible?
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Contributor
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
Just two minor edits. :) Looks great!
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
jmikell821
reviewed
Aug 23, 2022
Contributor
jmikell821
left a comment
jmikell821
left a comment
There was a problem hiding this comment.
Just a few suggestions ;)
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
* Creates Benchmark rules page * Minor edits * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> * Incorporates Janeen's feedback and some other edits * Minor edits * Fix build error * fixes image error Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 90b0e7e)
benironside
added a commit
that referenced
this pull request
Aug 24, 2022
* Creates Benchmark rules page * Minor edits * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> * Incorporates Janeen's feedback and some other edits * Minor edits * Fix build error * fixes image error Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 90b0e7e) Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
| @@ -1,2 +1,13 @@ | |||
| [[benchmark-rules]] | |||
| = Benchmark rules | |||
| The Benchmark Integrations page lets you view and manage cloud security posture (CSP) benchmark rules for each of your <<kspm, Kubernetes security posture management (KSPM) integrations>>. Enabled benchmark rules define the Kubernetes configuration best practices that form the basis of the data that appears on the <<cloud-posture-dashboard, Cloud Posture dashboard>>. | |||
Contributor
There was a problem hiding this comment.
The Benchmark Integrations page lets you view and manage the benchmark rules for each of your <<kspm, Kubernetes security posture management (KSPM) integrations>>. Enabled benchmark rules define the Kubernetes configuration best practices used to evaluate your Kubernetes resource, which goes on to form the basis of the data that appears on the <<cloud-posture-dashboard, Cloud Posture dashboard>>.
Contributor
There was a problem hiding this comment.
@benironside wdyt about replacing line 3 with the blurb above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2274 by creating a Benchmark rules page.
Preview: Benchmark rules
Meta:
#2260