Skip to content

Conversation

@jmikell821 jmikell821 added Team: Detections/Response Detections and Response readyforQA PRs that are ready for QA review. Feature: Rules v8.4.0 labels Aug 23, 2022
@jmikell821 jmikell821 self-assigned this Aug 23, 2022
@ghost
Copy link

ghost commented Aug 23, 2022

Hi @jmikell821 ,

The preview link for above changes is not available in this PR.
However, We have manage to get the preview link here and reviewed only this page.

We have found 2 issues.

Please let us know if there is any other preview link that we need to review.

Thanks!!

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few suggestions

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a handful of minor edits. Otherwise, LGTM!

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good updates here! I added a few revision suggestions.

I also suggest cropping the inline icon image saved-query-menu.png to leave just 1 pixel padding on each side, and no border. With all the extra padding, the icon itself ends up looking very small and hard to see.

image vs. image

@jmikell821 jmikell821 merged commit a2a21e7 into main Aug 24, 2022
mergify bot pushed a commit that referenced this pull request Aug 24, 2022
* Publishing branch for a quick save.

* Saving current edits.

* Slight edits.

* Addressing two quick bugs.

* Adding feedback.

(cherry picked from commit a2a21e7)
@jmikell821 jmikell821 mentioned this pull request Aug 24, 2022
20 tasks
jmikell821 added a commit that referenced this pull request Aug 24, 2022
* Publishing branch for a quick save.

* Saving current edits.

* Slight edits.

* Addressing two quick bugs.

* Adding feedback.

(cherry picked from commit a2a21e7)

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
acorretti pushed a commit that referenced this pull request Nov 19, 2024
* Publishing branch for a quick save.

* Saving current edits.

* Slight edits.

* Addressing two quick bugs.

* Adding feedback.

(cherry picked from commit a2a21e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Rules readyforQA PRs that are ready for QA review. Team: Detections/Response Detections and Response v8.4.0

Projects

None yet

6 participants