[DOCS] KSPM docs reorg #2539
Merged
[DOCS] KSPM docs reorg #2539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation previews: |
Contributor
|
@benironside, I noticed that the benchmark rules page and the posture dashboard don't appear underneath the KSPM section. Can you fix that?
|
Contributor
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
Looks great! Just left a few minor edits for your consideration. :)
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Contributor
Author
Thanks @tinnytintin10! I'm going to do that in a new PR to keep things simple. |
jmikell821
reviewed
Oct 14, 2022
Contributor
jmikell821
left a comment
jmikell821
left a comment
There was a problem hiding this comment.
Check your possessive AWS' references. I believe the extra 's at the end isn't needed, but feel free to correct me if I'm wrong here. Otherwise left general feedback. Thanks.
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
* KSPM docs reorg * Attempts to fix build error and removes outdated part of Benchmarks page * Fixes build error * testing build error * tests docs build * Takes another approach to build problems * Updates //comment * Update section headings for subordination * make dashboard page subordinate to KSPM page * Update docs/cloud-native-security/kspm.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/kspm.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/kspm.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/kspm.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/kspm.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Adds ToC and creates "Getting started" page * troubleshoots ToC issue * adds missing anchor * fixes build error * Add AWS auth details * troubleshoot headings/docs ToC * Minor fixes * minor updates * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/cloud-nat-sec-posture-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/cloud-native-security-index.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/findings.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/findings.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/findings.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Incorporates Joe's and Nastasha's feedback. * maintains dashboard doc parity * minor change * Incorporates Janeen's and Tinsae's feedback * minor fixes Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> (cherry picked from commit 1ac0a00)
benironside
added a commit
that referenced
this pull request
Oct 17, 2022
* KSPM docs reorg * Attempts to fix build error and removes outdated part of Benchmarks page * Fixes build error * testing build error * tests docs build * Takes another approach to build problems * Updates //comment * Update section headings for subordination * make dashboard page subordinate to KSPM page * Update docs/cloud-native-security/kspm.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/kspm.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/kspm.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/kspm.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/cloud-native-security/kspm.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Adds ToC and creates "Getting started" page * troubleshoots ToC issue * adds missing anchor * fixes build error * Add AWS auth details * troubleshoot headings/docs ToC * Minor fixes * minor updates * Update docs/cloud-native-security/benchmark-rules.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/cloud-nat-sec-posture-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/cloud-native-security-index.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/findings.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/findings.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/findings.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/cloud-native-security/get-started-with-kspm.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Incorporates Joe's and Nastasha's feedback. * maintains dashboard doc parity * minor change * Incorporates Janeen's and Tinsae's feedback * minor fixes Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> (cherry picked from commit 1ac0a00) Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2460 by reorganizing the KSPM documentation in the Cloud Native Security section to create a cohesive section that has all the info users might need to know about the topic. Also adds a guide for how to install the integration on Amazon EKS.
Preview