Skip to content

Conversation

@nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Oct 11, 2022

Addresses #2522, #2513, and #2512.

Previews:

@github-actions
Copy link

Documentation previews:

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of great stuff here, and a massive effort, thank you!

One general, big-picture question: Does this new "Use Osquery" section still belong inside the "Detections and alerts" parent section? With these new features (and more on the way I assume), It seems like Osquery cuts across several functions, not just detections & response but also investigation, threat hunting, etc. Maybe this should be a top-level section of its own?

nastasha-solomon and others added 3 commits October 12, 2022 17:41
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good changes here! One tiny tiny nit, then Joe had a question here. Other than that, I won't nit pick at this one further because I know it was a big PR. Thanks for pulling this together. 🌟

nastasha-solomon and others added 2 commits October 18, 2022 16:26
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2022

This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b osquery-8.5-features upstream/osquery-8.5-features
git merge upstream/main
git push upstream osquery-8.5-features

@nastasha-solomon nastasha-solomon merged commit b04b47f into main Oct 27, 2022
@nastasha-solomon nastasha-solomon deleted the osquery-8.5-features branch October 27, 2022 17:32
mergify bot pushed a commit that referenced this pull request Oct 27, 2022
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
(cherry picked from commit b04b47f)
nastasha-solomon added a commit that referenced this pull request Oct 27, 2022
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] Users can set up Osquery to run from a rule's investigation guide [DOCS] Osquery response action [DOCS] Osquery results can be added to case

8 participants