[DOCS] Value list exceptions for all rule types #2562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepeeples
added
Team: Docs
Team: Detections/Response
|
Documentation previews: |
joepeeples
requested review from
benironside,
dplumlee,
jethr0null,
jmikell821,
marshallmain and
nastasha-solomon
jmikell821
reviewed
Oct 12, 2022
Contributor
jmikell821
left a comment
jmikell821
left a comment
There was a problem hiding this comment.
Two small nits. LGTM, thanks!
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
ghost
added
QA:Validated
Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Update detections-ui-exceptions.asciidoc * Smol edits * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> * Apply suggestions from Marshall's review Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com> (cherry picked from commit c85062b)
joepeeples
added a commit
that referenced
this pull request
Oct 18, 2022
* Update detections-ui-exceptions.asciidoc * Smol edits * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> * Apply suggestions from Marshall's review Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com> (cherry picked from commit c85062b) Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2471.
Preview: Rule exceptions and value lists - Mostly updates the "Create value lists" sections
Note: Docs PR #2546 (New exceptions UI) is also updating portions of the "Rule exceptions and value lists" page, but I think we'll be able to avoid conflicts since we're working in different areas. 🤞