Skip to content

[DOCS] Alert counts added to Explore pages #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 18, 2022
Merged

[DOCS] Alert counts added to Explore pages #2576

merged 5 commits into from
Oct 18, 2022

Conversation

@jmikell821
Copy link
Contributor

@jmikell821 jmikell821 commented Oct 14, 2022 •
edited
Loading

@jmikell821 jmikell821 added Team: Threat Hunting Formerly Data Visibility v8.5.0 Feature: Entity Analytics Features or enhancements for any of the Entity pages labels Oct 14, 2022
@jmikell821 jmikell821 requested review from a team and jamster10 October 14, 2022 18:05
@jmikell821 jmikell821 self-assigned this Oct 14, 2022
@github-actions
Copy link

github-actions bot commented Oct 14, 2022

Documentation previews:

joepeeples
joepeeples reviewed Oct 16, 2022
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid updates, looks good! Added a few line-edits, etc.

Also: almost all the section headings here are just bold lines of text, not actual Asciidoc syntax for section headings & anchors. It looks like they've been this way for a long time, so we should probably either fix them now in this PR, or create a docs issue to make sure we get them fixed after the release crunch.

nastasha-solomon
nastasha-solomon approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few minor comments. Overall, LGTM!

@jmikell821 jmikell821 added the readyforQA PRs that are ready for QA review. label Oct 18, 2022
@jmikell821 jmikell821 mentioned this pull request Oct 18, 2022
Closed
28 tasks
benironside
benironside reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left some suggestions for your consideration, hope they are helpful.

@ghost
Copy link

ghost commented Oct 18, 2022

Hi @jmikell821

we have validated the shared doc preview links and doc information is complete and good to go.

Build Details:

Version:8.5.0 BC6
Commit:0b06c1437f38a9eb9a4273003d8d2ce2c8905189
Build:57022

Screen-Shot

image

Hence we are closing this issue and adding "QA:Validated" tag to it.

thanks !!

@ghost ghost closed this Oct 18, 2022
@ghost ghost reopened this Oct 18, 2022
@ghost ghost added the QA:Validated Issue has been Validated by QA Team label Oct 18, 2022
@jmikell821 jmikell821 merged commit f0cc44b into main Oct 18, 2022
@mergify mergify bot mentioned this pull request Oct 18, 2022
Merged
mergify bot pushed a commit that referenced this pull request Oct 18, 2022
@jmikell821 @mergify
[DOCS] Alert counts added to Explore pages (#2576)
fb7a294 
* Publishing edits.

* Slight edits.

* Merging feedback.

* Merging addt'l feedback.

(cherry picked from commit f0cc44b)
jmikell821 added a commit that referenced this pull request Oct 18, 2022
@mergify @jmikell821
[DOCS] Alert counts added to Explore pages (#2576) (#2593)
c332999 
* Publishing edits.

* Slight edits.

* Merging feedback.

* Merging addt'l feedback.

(cherry picked from commit f0cc44b)

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benironside benironside benironside left review comments

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

+2 more reviewers

@joepeeples joepeeples joepeeples left review comments

@jamster10 jamster10 jamster10 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmikell821 jmikell821

Labels

Feature: Entity Analytics Features or enhancements for any of the Entity pages QA:Validated Issue has been Validated by QA Team readyforQA PRs that are ready for QA review. Team: Threat Hunting Formerly Data Visibility v8.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DOCS] Alert counts added to Entity pages

6 participants

@jmikell821 @jamster10 @nastasha-solomon @joepeeples @benironside