Skip to content

Conversation

@nikitaindik
Copy link
Contributor

Epic: https://github.com/elastic/security-team/issues/1974
Related to: elastic/kibana#173594

Summary

API updates for elastic/kibana#180682.

Updates related API docs with required_field changes made in elastic/kibana#180682.

@nikitaindik nikitaindik added Team: Detections/Response Detections and Response API Feature: Rules Docset: ESS Issues that apply to docs in the Stack release v8.15.0 labels May 9, 2024
@nikitaindik nikitaindik self-assigned this May 9, 2024
@nikitaindik nikitaindik requested a review from a team as a code owner May 9, 2024 15:13
@github-actions
Copy link

github-actions bot commented May 9, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nikitaindik nikitaindik requested a review from joepeeples May 9, 2024 15:15
@nikitaindik nikitaindik changed the title Update docs for required_fields Update API docs for required_fields May 9, 2024
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this PR! I added a few possible edits for consideration.

nikitaindik and others added 2 commits May 10, 2024 00:44
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@nikitaindik
Copy link
Contributor Author

Thanks @joepeeples! I have committed your suggestions.

@nikitaindik nikitaindik requested a review from joepeeples May 9, 2024 22:45
@banderror banderror requested review from a team and dplumlee May 10, 2024 11:15
Copy link
Contributor

@dplumlee dplumlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nikitaindik nikitaindik merged commit f9012b2 into elastic:main May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Docset: ESS Issues that apply to docs in the Stack release Feature: Rules Team: Detections/Response Detections and Response v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants