Skip to content

Conversation

@benironside
Copy link
Contributor

@benironside benironside commented Nov 1, 2024

Fixes #5607 — Adds info to the cloud security section about how to incorporate third-party data from Wiz and AWS Security Hub into Elastic Security. This PR is for ESS docs only.

Previews:

There are also minor changes to the CSPM and CNVM Findings pages

@github-actions
Copy link

github-actions bot commented Nov 1, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link

@nick-alayil nick-alayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benironside Thank you for addressing all the changes from the first review.

I’ve added a few more minor comments, but after those adjustments, I think we’re set for the 8.16 release.

I'd also like to add a Validation section similar to this example. No rush on this. We can sync after this release and plan it as a next step.

nick-alayil
nick-alayil previously approved these changes Nov 5, 2024
Copy link

@nick-alayil nick-alayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🫶

@benironside benironside mentioned this pull request Nov 7, 2024
24 tasks
@benironside benironside marked this pull request as ready for review November 7, 2024 17:43
@benironside benironside requested a review from a team as a code owner November 7, 2024 17:43
@benironside benironside dismissed smriti0321’s stale review November 11, 2024 18:21

Incorporated Smriti's review

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggested edits, looks good and should be ready to approve soon. Thanks!

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benironside benironside enabled auto-merge (squash) November 11, 2024 20:50
@benironside benironside merged commit dc06264 into main Nov 11, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 11, 2024
* [ESS] [8.16] Ingest Sysdig Falco data to Elasticsearch

* fixes build error

* fixes kibana reference error

* adds information about 3p workflows to cloud native sec section

* fix build error

* save my work

* Incorporates Nick's review

* format tweaks for falco doc

* Incorporates Nick's second review

* Incorporates Joe's review

* Update docs/cloud-native-security/wiz.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit dc06264)
mergify bot pushed a commit that referenced this pull request Nov 11, 2024
* [ESS] [8.16] Ingest Sysdig Falco data to Elasticsearch

* fixes build error

* fixes kibana reference error

* adds information about 3p workflows to cloud native sec section

* fix build error

* save my work

* Incorporates Nick's review

* format tweaks for falco doc

* Incorporates Nick's second review

* Incorporates Joe's review

* Update docs/cloud-native-security/wiz.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit dc06264)
benironside added a commit that referenced this pull request Nov 11, 2024
* [ESS] [8.16] Ingest Sysdig Falco data to Elasticsearch

* fixes build error

* fixes kibana reference error

* adds information about 3p workflows to cloud native sec section

* fix build error

* save my work

* Incorporates Nick's review

* format tweaks for falco doc

* Incorporates Nick's second review

* Incorporates Joe's review

* Update docs/cloud-native-security/wiz.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit dc06264)

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
benironside added a commit that referenced this pull request Nov 11, 2024
* [ESS] [8.16] Ingest Sysdig Falco data to Elasticsearch

* fixes build error

* fixes kibana reference error

* adds information about 3p workflows to cloud native sec section

* fix build error

* save my work

* Incorporates Nick's review

* format tweaks for falco doc

* Incorporates Nick's second review

* Incorporates Joe's review

* Update docs/cloud-native-security/wiz.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit dc06264)

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
acorretti pushed a commit that referenced this pull request Nov 19, 2024
* [ESS] [8.16] Ingest Sysdig Falco data to Elasticsearch

* fixes build error

* fixes kibana reference error

* adds information about 3p workflows to cloud native sec section

* fix build error

* save my work

* Incorporates Nick's review

* format tweaks for falco doc

* Incorporates Nick's second review

* Incorporates Joe's review

* Update docs/cloud-native-security/wiz.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit dc06264)
acorretti pushed a commit that referenced this pull request Nov 19, 2024
* [ESS] [8.16] Ingest Sysdig Falco data to Elasticsearch

* fixes build error

* fixes kibana reference error

* adds information about 3p workflows to cloud native sec section

* fix build error

* save my work

* Incorporates Nick's review

* format tweaks for falco doc

* Incorporates Nick's second review

* Incorporates Joe's review

* Update docs/cloud-native-security/wiz.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit dc06264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request] 3P Integrations data in native Posture workflows

4 participants