Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 5, 2019

Depends on elastic/docs#1148

This PR changes the location of the shared version attributes (so that updates are not required every time there's a new branch).

NOTE: The source_branch attribute definition should be removed from this PR after elastic/docs#1147 is merged.

@lcawl lcawl added WIP Work in progress v8.0.0 labels Sep 5, 2019
:stack-repo-dir: {docdir}
:beats-repo-dir: {docdir}/../../../../beats/libbeat/docs
include::{asciidoc-dir}/../../shared/versions.asciidoc[]
include::{asciidoc-dir}/../../shared/versions/stack/{source_branch}.asciidoc[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lcawl lcawl removed the WIP Work in progress label Sep 6, 2019
@lcawl lcawl marked this pull request as ready for review September 6, 2019 17:01
@lcawl lcawl merged commit 4346561 into elastic:master Sep 6, 2019
@lcawl lcawl deleted the branch-version-attributes branch September 6, 2019 17:31
@lcawl lcawl added the v7.5.0 label Sep 6, 2019
@lcawl lcawl added the v7.4.0 label Sep 6, 2019
@lcawl lcawl added the v7.2.2 label Sep 6, 2019
@lcawl lcawl added the v7.1.2 label Sep 6, 2019
@lcawl lcawl added the v7.0.2 label Sep 6, 2019
@lcawl lcawl added the v6.8.4 label Sep 6, 2019
@lcawl lcawl added the v6.7.3 label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants