Skip to content

Updates the flow metrics view in Logstash's diagnostic creation#978

Merged
pickypg merged 5 commits intoelastic:mainfrom
andsel:feature/update_logstash_snapshot_to_include_batch_structure
Apr 15, 2026
Merged

Updates the flow metrics view in Logstash's diagnostic creation#978
pickypg merged 5 commits intoelastic:mainfrom
andsel:feature/update_logstash_snapshot_to_include_batch_structure

Conversation

@andsel
Copy link
Copy Markdown
Member

@andsel andsel commented Mar 10, 2026

Updates the flow metrics view in Logstash's diagnostic creation to include batch structure metrics informations, for current, average and windowed p50 and p90

Checklist

  • I have verified that the APIs in this pull request do not return sensitive data

What the PR does?

Updates the HTML template file used to generate the report bundled with Logstash diagnostic to expose a table with batch structure metric informations, retrieved directly from Logstash HTTP API.

Following a set of snapshots of the updated section:

Screenshot 2026-03-10 at 13 53 36 Screenshot 2026-03-10 at 13 53 48 Screenshot 2026-03-10 at 13 53 59

@andsel andsel marked this pull request as ready for review March 10, 2026 12:50
@andsel andsel requested review from a team and pickypg as code owners March 10, 2026 12:50
@andsel andsel changed the title Updates the flow metrics view in Logstash's diagnostic creation to in… Updates the flow metrics view in Logstash's diagnostic creation Mar 10, 2026
@lucabelluccini
Copy link
Copy Markdown
Contributor

Thank you @andsel - I only have 1 concern on the table.
For the actual merge/approve, we'll need Chris Earle.

@andsel
Copy link
Copy Markdown
Member Author

andsel commented Mar 26, 2026

@lucabelluccini, it works, but present an empty table like:
Screenshot 2026-03-26 at 10 15 07

I'll try to have that section present iff the LS version provides that data.

@andsel
Copy link
Copy Markdown
Member Author

andsel commented Mar 26, 2026

Conditionally display Batch structure metrics, and p50/p90 columns, only if present in the dataset.

@andsel andsel requested a review from lucabelluccini March 26, 2026 10:39
@andsel
Copy link
Copy Markdown
Member Author

andsel commented Mar 26, 2026

Hi @pickypg please could you give it an eye to this :-)

@pickypg pickypg enabled auto-merge (squash) April 9, 2026 17:03
auto-merge was automatically disabled April 13, 2026 08:00

Head branch was pushed to by a user without write access

@andsel andsel force-pushed the feature/update_logstash_snapshot_to_include_batch_structure branch from 08d0892 to 6e82618 Compare April 13, 2026 08:00
@andsel
Copy link
Copy Markdown
Member Author

andsel commented Apr 14, 2026

Hi @pickypg could you help me get BK task run and merge this PR?

Comment thread README.md Outdated
@pickypg
Copy link
Copy Markdown
Member

pickypg commented Apr 14, 2026

We can skip Buildkite for now. It doesn't actually do anything helpful here, but it will soon build the Docker image for us.

@pickypg pickypg merged commit 942d7ad into elastic:main Apr 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants