[Audit Fix] Incorrect triggering of Approval event

[dmvt]

Incorrect event parameters in transferFrom()

Risk Rating

Impact = Medium Likelihood = High Risk = High (per OWASP)

Vulnerability Details

The event should be emit Approval(from, msg.sender, _allowances[_from][msg.sender]); instead of emit Approval(msg.sender, _to, _allowances[_from][msg.sender]);

because the event is emitted when msg.sender != _from as specified in the conditional.

Impact

This incorrect event emission will negatively impact any off-chain tools monitoring these critical transfer events of the governance token.

Definition of Done

• Approval event emission uses the correct parameters