Docs issue#6#52
Merged
parisaelasticpath merged 4 commits intomainfrom Apr 5, 2022
Merged
Conversation
steve-r-west
requested changes
Apr 5, 2022
Comment on lines
+15
to
+34
| if len(args) != 0 { | ||
| resource := resources.Resources[args[0]] | ||
| url := resource.Docs | ||
|
|
||
| switch runtime.GOOS { | ||
| case "linux": | ||
| exec.Command("xdg-open", url).Start() | ||
| case "windows": | ||
| exec.Command("rundll32", "url.dll,FileProtocolHandler", url).Start() | ||
| case "darwin": | ||
| exec.Command("open", url).Start() | ||
| default: | ||
| fmt.Errorf("unsupported platform") | ||
| } | ||
| return nil | ||
| // return fmt.Errorf("This function is not implemented") | ||
|
|
||
| } else { | ||
| return fmt.Errorf("You must supply a resource type to the docs command") | ||
| } |
Collaborator
There was a problem hiding this comment.
Can we refactor this so that your and @mahsaelasticpath 's commands call a function to open a URL, instead of copying and pasting it?
Contributor
Author
There was a problem hiding this comment.
I added a separate file name "share", Done
steve-r-west
reviewed
Apr 5, 2022
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| return fmt.Errorf("This function is not implemented") | ||
| if len(args) != 0 { | ||
| resource := resources.Resources[args[0]] |
Collaborator
There was a problem hiding this comment.
What happens if the resource doesn't exist?
Contributor
Author
There was a problem hiding this comment.
Done
returning error as below
return fmt.Errorf("You must supply a valid resource type to the docs command")"
steve-r-west
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs command support #6