Replaced spinner with skeleton on plp #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
long-wan-ep
changed the title
long-wan-ep
changed the title
long-wan-ep
changed the title
dr-ep
suggested changes
Apr 16, 2021
package.json
Outdated
| "private": true, | ||
| "dependencies": { | ||
| "@material-ui/core": "^4.11.3", | ||
| "@material-ui/lab": "^4.0.0-alpha.57", |
Contributor
There was a problem hiding this comment.
We shouldn't be adding material ui to the ref-store. It will definitely increase the bundle size and the loading times.
I see that you are using it only for the Skeleton component. You can probably implement this with pure css.
Contributor
Author
There was a problem hiding this comment.
Ok, I will change this.
long-wan-ep
changed the title
long-wan-ep
changed the title
dr-ep
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replaced spinner with skeleton components on plp.
Linting:
Tests:
Documentation: