Skip to content

[MT-23080] feat: add optional id to rule-promotion Action#95

Merged
ellanan merged 1 commit into
mainfrom
feature/MT-23080-add-action-id-to-type
May 22, 2026
Merged

[MT-23080] feat: add optional id to rule-promotion Action#95
ellanan merged 1 commit into
mainfrom
feature/MT-23080-add-action-id-to-type

Conversation

@ellanan
Copy link
Copy Markdown
Collaborator

@ellanan ellanan commented May 22, 2026

Type

  • Feature

    Implements a new feature

Description

Backend (promotions.svc!895) now assigns a UUID to each action on a rule promotion and matches actions by id on update. Adding an optional id field lets consumers round-trip it without losing type safety.

The field is intentionally optional: it is absent on create requests and on legacy promotion responses prior to backend backfill.

Dependencies

[MT-23080] Include action UUID on update in promotion builder

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

Test Results

  1 files  ±0   60 suites  ±0   2s ⏱️ ±0s
367 tests ±0  367 ✅ ±0  0 💤 ±0  0 ❌ ±0 
372 runs  ±0  372 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 32a788f. ± Comparison against base commit 4f1c6c7.

♻️ This comment has been updated with latest results.

Backend (promotions.svc!895) now assigns a UUID to each action on a rule promotion and matches actions by id on update. Adding an optional id field lets consumers round-trip it without losing type safety.

The field is intentionally optional: it is absent on create requests and
on legacy promotion responses prior to backend backfill.
@ellanan ellanan force-pushed the feature/MT-23080-add-action-id-to-type branch from 1a3f1d2 to 32a788f Compare May 22, 2026 19:52
@ellanan ellanan changed the title [MT-23080] feat(types): add optional id to rule-promotion Action [MT-23080] feat: add optional id to rule-promotion Action May 22, 2026
@ellanan ellanan requested a review from wberry22 May 22, 2026 20:42
@ellanan ellanan merged commit 459b42a into main May 22, 2026
11 checks passed
@ellanan ellanan deleted the feature/MT-23080-add-action-id-to-type branch May 22, 2026 21:23
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 34.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants