fix(plasmic-mcp): Tier 3+4 — removal/states, interaction DX, expression safety#198
Merged
Conversation
…ibility, cascade delete - node.remove fallback path: call removeImplicitStatesAfterRemovingTplNode from @/wab/shared/core/states before manual splice for TplComponent nodes without parent pointers (#55) - list-states: add includeImplicit parameter to expose implicit states created by TplComponent instances and variant groups (#56) - component.delete with force: cascade-remove all TplComponent instances referencing the deleted component via TplQuery tryRemove({ deep: true }) before calling TplMgr.removeComponent (#58)
…pe correction, arg validation - $state. prefix stripping: buildActionArgs updateVariable strips accidental $state. prefix from variable arg to prevent $state.$state.x double-prefix (#47) - Bare scope variable auto-correction: createAttrExpr detects props.x/state.x/ctx.x after $ stripping and re-adds the $ prefix with a warning (#31) - $expr: rejection: createAttrExpr explicitly rejects $expr: prefix with clear error pointing to $expression or {{expression}} syntax (#54) - customFunction arg validation: warns on unknown arg keys (#49) - Event variable documentation: interaction.add tool description now documents that customFunction code has access to event, $state, $props, $ctx, $steps (#48) - buildActionArgs returns { nameArgs, warnings } for warning propagation
field123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two tiers of fixes in one PR:
Tier 3: Component Removal & Implicit States (55, 56, 58)
removeImplicitStatesAfterRemovingTplNode()from@/wab/shared/core/statesbefore manual splice for TplComponent nodescomponent.list-statesacceptsincludeImplicitboolean to expose implicit states withimplicit: trueandtplNodeUuidmarkerscomponent.deletewithforce: truecascade-removes all TplComponent instances via TplQuerytryRemove({ deep: true })before callingTplMgr.removeComponentTier 4: Interaction & Expression DX (47, 31, 49, 48, 54)
buildActionArgsstrips accidental$state.prefix from updateVariable variable arg to prevent$state.$state.xcreateAttrExprdetectsprops.x/state.x/ctx.xafter$stripping and re-adds the$prefix with a warning$expressionor{{expression}}syntaxevent,$state,$props,$ctx,$stepsavailabilityAlso confirmed during this session: Gaps 26, 29 (hostless components), 33 (toggle variant), 34 (visibility alias), 39 (toggle auto-value) are all already fixed by prior PRs.
Test plan