feat(ep-commerce): enrich EPSearchPagination default slot with Prev/Next chrome#312
Merged
Conversation
…ext chrome (#311) Replace the placeholder text-only slot with an hbox of [Prev button, page text, Next button] so a fresh drop-in renders working pagination shape. Mirrors the same pattern EPSearchBox ships post-#308. Wiring (onClick → ref-actions, visibility → hasPrev/hasNext) is still designer-side; this only changes the structural starting point so designers do not begin from a single text node. - defaultValue: text("Page 1 of 4") → hbox(button, text, button) - description: spell out the wiring contract (data fields + ref-actions) - README: add "Composing EPSearchPagination" subsection - test: lock in the slot shape so future refactors do not regress
7671dc5 to
01d59b4
Compare
This was referenced May 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #311.
Summary
EPSearchPagination's placeholder slot (text("Page 1 of 4")) with a structural starting point —hboxcontainingPrevbutton, page-text,Nextbutton — so a fresh drop renders working pagination shape.EPSearchBoxships post-PRD: Make EPSearchBox styleable by lifting its DOM out of the code-component #308: structural skeleton only, wiring (onClick→prevPage/nextPageref-actions, visibility →hasPrev/hasNext) is designer-side because Plasmic registration metadata cannot bake bindings intodefaultValue.Composing EPSearchPaginationsubsection paralleling the existingComposing EPSearchBoxwalkthrough.Test plan
yarn jest plasmicpkgs/commerce-providers/elastic-path— 1523 tests pass (1 added)9iSL9GyrJNp9ebWzxaHtM5(ProductList page) — Prev / page-text / Next render in Studio canvas. Visibility + ref-action wiring still requires Studio UI per gap add enhanced container insights #81 / PRD PRD: Expose Plasmic'sinvokeRefActioninteraction type in the MCP (gap #81) #310, same as forEPSearchBox.defaultValueonly applies to fresh drops).Out of scope
invokeRefActioninteraction type in the MCP (gap #81) #310.EPSearchPagination.