Skip to content

RS-840 - update token fetch on app initialization #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shaunmaharaj merged 2 commits into from
Jun 10, 2020
Merged

RS-840 - update token fetch on app initialization #740

shaunmaharaj merged 2 commits into from
Jun 10, 2020

Conversation

@yulia-dnistrian
Copy link
Contributor

@yulia-dnistrian yulia-dnistrian commented Jun 9, 2020 •
edited
Loading

Description:

Linting:

  • No linting errors

Tests:

  • E2E tests (npm test run with e2e)
  • Manual tests
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

@yulia-dnistrian yulia-dnistrian changed the title RS-840 - update token fetch on app initialization [WIP] RS-840 - update token fetch on app initialization Jun 9, 2020
shaunmaharaj
shaunmaharaj reviewed Jun 9, 2020
View reviewed changes
shaunmaharaj
shaunmaharaj approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@shaunmaharaj shaunmaharaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Yulia. Are there any other components that we should need to update for this (any others with login()?) or are the major header components enough?

@shaunmaharaj
Copy link
Contributor

shaunmaharaj commented Jun 9, 2020

@yulia-dnistrian I'm good with merging this once we remove the WIP tag and confirm the last comment. Thank you for pushing this! 😃

@aChanEP
Copy link
Contributor

aChanEP commented Jun 10, 2020 •
edited
Loading

@yulia-dnistrian Great work on this! Although we may need replace all login().then with this newchecklogin() function. When clearing the cache and reloading the page on other pages besides the homepage the app will still fetch the token twice.

Screen Shot 2020-06-09 at 9 31 39 PM

This is what you will see in the CartPage for example.

@yulia-dnistrian yulia-dnistrian changed the title [WIP] RS-840 - update token fetch on app initialization RS-840 - update token fetch on app initialization Jun 10, 2020
@shaunmaharaj shaunmaharaj merged commit 9213c12 into master Jun 10, 2020
@shaunmaharaj shaunmaharaj deleted the RS-840-update-token-fetch branch June 10, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aChanEP aChanEP Awaiting requested review from aChanEP

1 more reviewer

@shaunmaharaj shaunmaharaj shaunmaharaj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yulia-dnistrian @shaunmaharaj @aChanEP