Ingress-nginx upgrade #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlleLarsson
requested review from
Xartos,
aarnq,
cristiklein,
crssnd,
robinAwallace and
viktor-f
cristiklein
approved these changes
Feb 9, 2022
Contributor
cristiklein
left a comment
cristiklein
left a comment
There was a problem hiding this comment.
LGTM, but didn't test.
Should we update the user demo Ingress to specify an ingressClass?
Contributor
Author
I would say yes as the annotation is deprecated. |
Contributor
|
@OlleLarsson Your wish is my ticket. 😄 |
robinAwallace
approved these changes
Feb 11, 2022
OlleLarsson
force-pushed
the
ol/v1-ingress-nginx
branch
from
2fee661 to
ddb56b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrades the ingress-nginx helm chart to latest.
This bumps ingress-nginx to v1.x.x
This is needed as to support k8s >=1.22
The biggest change is the requirement of an ingressClass.
Which issue this PR fixes:
fixes #805
Public facing documentation PR:
Special notes for reviewer:
Checklist:
E.g. logs or metrics are not being collected or Kubernetes API server
will not be responding while upgrading.
E.g. removes or changes any CK8S config options or Kubernetes APIs.
I.e. full cluster migration is required.
Pipeline config (if applicable)
If you change some config options (e.g. add/rename variable or change the default value) you may need to update the config used by the pipeline in
pipeline/config.