Add support for nodegroup matching and update to newer deps#5
Merged
Add support for nodegroup matching and update to newer deps#5
Conversation
… from old versions
zrk02
reviewed
Apr 25, 2024
zrk02
approved these changes
May 3, 2024
Contributor
zrk02
left a comment
zrk02
left a comment
There was a problem hiding this comment.
A lot going on here.
Cannot say more than it seems reasonable and at least not blatantly fishy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to support upgrading from v1alpha1 however this is working asis if the old CRD is removed first.
You are able to update from the latest release v0.3 directly to this version. However will need to update your resource from
apiVersion: k8s.elx.cloud/v1alpha1toapiVersion: k8s.elx.cloud/v1alpha2in order to use the new nodegroup matching